Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: bump unique-selector #28571

Merged
merged 4 commits into from
Dec 28, 2023
Merged

Conversation

jennifer-shehane
Copy link
Member

  • Closes

Additional details

This includes a performance optimization to cypress/unique-selector, perhaps the Selector playground will be slightly faster in some cases. https://github.com/cypress-io/unique-selector/releases/tag/v0.0.5

Steps to test

Current tests should pass

How has the user experience changed?

PR Tasks

@jennifer-shehane jennifer-shehane self-assigned this Dec 21, 2023
@MikeMcC399
Copy link
Contributor

@jennifer-shehane

It's a little unusual for a version 0.4.4 to be "bumped" to 0.0.5, which is a lower semver version.

Perhaps 0.5.0 should have been published, not 0.0.5?

@jennifer-shehane
Copy link
Member Author

@MikeMcC399 Yah it's weird because I implemented semantic-versioning for the first time and it did something strange with it and I don't really want to spend more effort on it. https://github.com/cypress-io/unique-selector/releases/tag/v0.0.5

@MikeMcC399
Copy link
Contributor

@jennifer-shehane

I guess it will work, although it is confusing especially as the https://github.com/cypress-io/unique-selector/blob/master/README.md is also not aligned to the release versions, content and contacts for the fork.

@emilyrohrbough
Copy link
Member

@jennifer-shehane We need a changelog entry for this dependency bump

Copy link

cypress bot commented Dec 28, 2023

4 flaky tests on run #53095 ↗︎

0 554 6 0 Flakiness 4

Details:

Merge branch 'develop' into bump-unique-selector-dep
Project: cypress Commit: cf3fa72c0d
Status: Passed Duration: 12:49 💡
Started: Dec 28, 2023 11:20 PM Ended: Dec 28, 2023 11:33 PM
Flakiness  runs.cy.ts • 2 flaky tests • app-e2e

View Output

Test Artifacts
App: Runs > Runs - Create Project > when a project is created, injects new projectId into the config file, and sends expected UTM params Test Replay Screenshots
App: Runs > Runs - Cannot Find Project > opens Connect Project modal after clicking Reconnect Project button Test Replay Screenshots
Flakiness  top-nav.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
... > dismisses the banner for a specified time Test Replay Screenshots
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Screenshots

Review all test suite changes for PR #28571 ↗︎

@jennifer-shehane jennifer-shehane merged commit 83c5a94 into develop Dec 28, 2023
81 of 83 checks passed
@jennifer-shehane jennifer-shehane deleted the bump-unique-selector-dep branch December 28, 2023 23:55
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 17, 2024

Released in 13.6.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.3, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants