fix: studio generated assertions now use proper past tense for assertions

[jennifer-shehane]

Additional details

When you generate assertions within Cypress Studio, we insert a little preview of the assertions right away while the assertions are being written to your code. It doesn't refresh and run what is in your codebase right away - it generates a fake preview.

Previously this preview was showing the text 'expect....' for assertions, but in reality assertions always show in the past tense as 'expected...'. You can see this behavior after saving the commands - when they run, it switches from 'expect' to 'expected'

I found this while working on this PR because I created a regex to capture all assertion text and this was the one test that failed and borked up when going through the regex. Baffling!

Well the hard written generated assertion is incorrect and the test was written to verify the incorrect behavior. This updates both.

Steps to test

Not sure I would bother with a true test to prevent this in the future. 🤔 But you can run cypress with studio, add an assertion - see that it writes 'expected' and then the same thing after saving the file should display as 'expected'.

How has the user experience changed?

Before

After

PR Tasks

• Have tests been added/updated?
• [NA] Has a PR for user-facing changes been opened in cypress-documentation?
• [NA] Have API changes been updated in the type definitions?

[cypress]

31 flaky tests on run #53055 ↗︎

0

28305

1347

0

31

Details:

Merge branch 'develop' into fix-studio-generated-assertions
Project: cypress	Commit: ff5a839690
Status: Passed	Duration: 18:48 💡
Started: Dec 28, 2023 3:18 PM	Ended: Dec 28, 2023 3:36 PM

  commands/files.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test		Artifacts
... > passes through assertion error when not about existence		Test Replay

  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output

Test		Artifacts
... > correctly returns currentRetry		Test Replay
... > correctly returns currentRetry		Test Replay
... > correctly returns currentRetry		Test Replay

  runs.cy.ts • 2 flaky tests • app-e2e

View Output

Test		Artifacts
App: Runs > Runs - Cannot Find Project > opens Connect Project modal after clicking Reconnect Project button		Test Replay Screenshots
... > displays a list of recorded runs if a run has been recorded		Test Replay Screenshots

  cypress-in-cypress.cy.ts • 2 flaky tests • app-e2e

View Output

Test		Artifacts
Cypress in Cypress > scales the AUT correctly in component		Test Replay Screenshots
Cypress in Cypress > restarts browser if there is a before:browser:launch task and there is a change on the config		Test Replay Screenshots

  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs		Test Replay Screenshots

The first 5 flaky specs are shown, see all 18 specs in Cypress Cloud.

Review all test suite changes for PR #28593 ↗︎

[jordanpowell88]

This is quite the find. Change looks good to me.

[cypress-bot]

Released in 13.6.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.3, please open a new issue.