Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: protocol supports body highlight element #28627

Merged
merged 4 commits into from Jan 5, 2024

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Jan 3, 2024

Additional details

The unique selector to determine the highlight selector for Test Replay for the body element (i.e. when a user does cy.get('body')) is not being correctly returned because we are passing in the body instead of the ownerDocument to finder.

Steps to test

How has the user experience changed?

Protocol now contains the correct unique selector for a body element.

PR Tasks

Copy link

cypress bot commented Jan 3, 2024

10 flaky tests on run #53270 ↗︎

0 5507 972 0 Flakiness 10

Details:

Merge branch 'develop' into mschile/protocol/body_highlight
Project: cypress Commit: e855f2bdf3
Status: Passed Duration: 13:56 💡
Started: Jan 5, 2024 4:34 PM Ended: Jan 5, 2024 4:48 PM
Flakiness  src/debug/empty/DebugEmptyStates.cy.tsx • 1 flaky test • app-ct

View Output

Test Artifacts
... > renders slideshow Test Replay Screenshots
Flakiness  cypress/e2e/project-setup.cy.ts • 2 flaky tests • launchpad-e2e

View Output

Test Artifacts
... > shows the configuration setup page when selecting e2e tests Test Replay Screenshots
... > can skip setup CT testing for an E2E project Test Replay Screenshots
Flakiness  cypress/e2e/commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/53270/overview/3a07b773-ca43-4c9b-ad82-5a41d48f89c3?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > with `times` > only uses each handler N times
      </a>
    </td>
    <td>
      
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/53270/overview/e2b705cf-57ea-4051-bcff-ebc25c46c8e4?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > stops waiting when an xhr request is canceled
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>
Flakiness  cypress/e2e/commands/waiting.cy.js • 1 flaky test • 5x-driver-webkit

View Output

Test Artifacts
... > errors > throws waiting for the 3rd response
    </td>
  </tr></table>
Flakiness  cypress/e2e/cypress/cypress.cy.js • 3 flaky tests • 5x-driver-webkit

View Output

Test Artifacts
... > correctly returns currentRetry
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/53270/overview/a4603be1-4c70-4a6e-b75b-ee7c41a1670c?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > correctly returns currentRetry
      </a>
    </td>
    <td>
      
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/53270/overview/d9a11a7f-9a1e-44eb-8a41-08a1d09e19f1?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > correctly returns currentRetry
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>

Review all test suite changes for PR #28627 ↗︎

@mschile mschile merged commit 1cba68f into develop Jan 5, 2024
80 of 82 checks passed
@mschile mschile deleted the mschile/protocol/body_highlight branch January 5, 2024 19:17
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 17, 2024

Released in 13.6.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.3, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants