New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: protocol supports body highlight element #28627
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthemanuel
approved these changes
Jan 3, 2024
10 flaky tests on run #53270 ↗︎
Details:
src/debug/empty/DebugEmptyStates.cy.tsx • 1 flaky test • app-ct
cypress/e2e/project-setup.cy.ts • 2 flaky tests • launchpad-e2e
cypress/e2e/commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit
|
chrisbreiding
approved these changes
Jan 5, 2024
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
The unique selector to determine the highlight selector for Test Replay for the
body
element (i.e. when a user doescy.get('body')
) is not being correctly returned because we are passing in thebody
instead of theownerDocument
tofinder
.Steps to test
How has the user experience changed?
Protocol now contains the correct unique selector for a
body
element.PR Tasks
cypress-documentation
?type definitions
?