Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Fix some a11y violations using Cypress Cloud #28628

Merged
merged 9 commits into from
Jan 10, 2024
Merged

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Jan 3, 2024

Additional details

Playing around with our early access accessibility checks in the Cypress Cloud to see what the workflow is like to fix them and maybe fix some violations also.

Fixing the following a11y violations found in the Cloud.

Steps to test

This upped our a11y coverage on the launchpad tests from 98% to 99% (excludes contrast color checking for now)

How has the user experience changed?

PR Tasks

Copy link

cypress bot commented Jan 3, 2024

4 flaky tests on run #53375 ↗︎

0 5513 75 0 Flakiness 4

Details:

Update packages/frontend-shared/src/gql-components/topnav/PromptContent.vue
Project: cypress Commit: de5c9f9693
Status: Passed Duration: 15:14 💡
Started: Jan 10, 2024 4:58 PM Ended: Jan 10, 2024 5:13 PM
Flakiness  commands/waiting.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > errors > throws when waiting for 2nd response to route Test Replay
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output

Test Artifacts
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay

Review all test suite changes for PR #28628 ↗︎

@jennifer-shehane jennifer-shehane changed the title misc: Attempt to fix a11y violations using Cypress Cloud misc: Fix some a11y violations using Cypress Cloud Jan 9, 2024
…nt.vue

Co-authored-by: Bill Glesias <bglesias@gmail.com>
@jennifer-shehane jennifer-shehane merged commit 765b859 into develop Jan 10, 2024
80 of 82 checks passed
@jennifer-shehane jennifer-shehane deleted the a11y-fixes branch January 10, 2024 17:23
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 17, 2024

Released in 13.6.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.3, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants