fix: prevent timing out on short/skipped videos

[emilyrohrbough]

• Closes 'Warning: We failed capturing this video' error when tests are very short duration (2 secs or less) or skipped #27898

This change prevents timing out when creating videos for short or skipped specs. This change will:

1. if the spec was skipped by the cloud , immediately end- we know no more frames are coming
2. otherwise, wait for 3000 ms for at least frames, then end regardless of frames written

The originally timeout logic was introduced because ffmpeg crashes in firefox if less than 2 frames were written to the input stream. This changed technically could resurfaces #6408, where the error We failed to record the video was observed for less than 2 frames. However, under the circumstances additional frames were never written, the fix to handle the We failed to record the video error was just replaced the We failed to capture ... TimeoutError error reported in #27898.

To handle the known scenario where ffmpeg did not receive enough frames, the error message has been updated to provide context to the Cypress issue.

Before	After

Steps to test

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[cypress]

2 flaky tests on run #53421 ↗︎

0

551

8

0

2

Details:

Update CHANGELOG.md
Project: cypress	Commit: 37f1266bd3
Status: Passed	Duration: 12:22 💡
Started: Jan 11, 2024 3:39 PM	Ended: Jan 11, 2024 3:51 PM

  runs.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
... > displays a list of recorded runs if a run has been recorded		Test Replay Screenshots

  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs		Test Replay Screenshots

Review all test suite changes for PR #28643 ↗︎

[cypress-bot]

Released in 13.6.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.3, please open a new issue.