New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(a11y): Update <ul> and roles to be accurate to their intended purpose in launchpad UI #28774
Conversation
36 flaky tests on run #53833 ↗︎
Details:
commands/querying/querying.cy.js • 2 flaky tests • 5x-driver-electron
e2e/origin/origin.cy.ts • 1 flaky test • 5x-driver-firefox
|
<li role="option"> | ||
<slot name="footer" /> | ||
</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you didn't add this, but looking at the code + screenshot, this is a super bizzare usage to place an info/link item in the select 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is!
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Fixing some a11y issues found while using Cypress Cloud Accessibility Beta mostly around this dropdown in the Launchpad
Additional details
Cypress a11y violation: I think this is reporting incorrectly, see Slack, but updating the structure of the DOM to have proper nesting of ul > li > div resolved it.
Cypress a11y violation: Every element within a listbox must have role=option. I wrapped the footer of the select in an li element with a role=option.
I updated a test to accommodate for the new update, but also rewrote it to be more descriptive when it fails and less brittle to HTML changes. It was failing with this nondescript error before.
Steps to test
Check percy snapshots to ensure they have not changed. Check Cypress a11y score to see they are lower for launchpad.
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?