fix: Disabled elements being clickable

[TheoAnastasiadis]

• Closes Clicking nested element in disabled button invokes button's onclick handler #28788

Additional details

Click commands on children of disabled elements still produce click events.
For example the following;

<button disabled>
  <span>Click Me!</span>
</button>

cy.contains("Click Me!").click() // this triggers `click` events (at least on Chrome).

Even though the button element is disabled.

How has the user experience changed?

Little

PR Tasks

• Have tests been added/updated?
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?

[CLAassistant]

All committers have signed the CLA.

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[jennifer-shehane]

@TheoAnastasiadis Thanks for the contribution. Please see this failing check for details about adding a changelog entry: https://github.com/cypress-io/cypress/actions/runs/7670111753/job/20905527788?pr=28807

[AtofStryker]

Hi @TheoAnastasiadis! Thank you for the contribution PR. I had some issues getting the added code in mouse.ts to work correctly. Were you able to run the code changes against the cypress test or was this a best guess effort? Either way I think we can get this running with the suggestions below.

[TheoAnastasiadis]

Hi @TheoAnastasiadis! Thank you for the contribution PR. I had some issues getting the added code in mouse.ts to work correctly. Were you able to run the code changes against the cypress test or was this a best guess effort? Either way I think we can get this running with the suggestions below.

this was embarrassing 😳 is ok now, what should the release date of 13.6.5 be?

[jennifer-shehane]

@TheoAnastasiadis 2 weeks from the previous release is the target, so 2/13/2024

[AtofStryker]

Hi @TheoAnastasiadis! Thank you for the contribution PR. I had some issues getting the added code in mouse.ts to work correctly. Were you able to run the code changes against the cypress test or was this a best guess effort? Either way I think we can get this running with the suggestions below.

this was embarrassing 😳 is ok now, what should the release date of 13.6.5 be?

no worries @TheoAnastasiadis! We've all been there before 🙂 . CI should be running against the PR now.

[AtofStryker]

Besides the changelog edits I think we are good to go! Going to wait for CI test feedback then will re review

[AtofStryker]

Suggested change

	Fixed an issue where `.click()` commands on children of disabled elements would still produce "click" events -- even without `{ force: true }`. Fixes [#28788](https://github.com/cypress-io/cypress/issues/28788).
	- Fixed an issue where `.click()` commands on children of disabled elements would still produce "click" events -- even without `{ force: true }`. Fixes [#28788](https://github.com/cypress-io/cypress/issues/28788).

Needs changelog updates before merge

[cypress-bot]

Released in 13.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.7.0, please open a new issue.