fix: Hanging indefinitely when unzip fails with an empty error

[CamilleDrapier]

It seems the promise for trying to unzip with Node extract was not always either resolved or rejected. There shouldn't be a case where this shouldn't be done once the fallback has been tried.

Additional details

Sometimes on my CI, I see the following log:

2024-02-02T05:07:52.724Z cypress:cli expected file size 183022418
2024-02-02T05:07:54.537Z cypress:cli downloading finished
2024-02-02T05:07:54.537Z cypress:cli only checking expected file size 183022418
2024-02-02T05:07:54.538Z cypress:cli downloaded file has the expected size ✅
2024-02-02T05:07:54.538Z cypress:cli verified
2024-02-02T05:07:54.538Z cypress:cli finished downloading file: /tmp/cypress-262.zip
[SUCCESS] Task without title.
[STARTED] Task without title.
2024-02-02T05:07:54.539Z cypress:cli:unzip unzipping from /tmp/cypress-262.zip
2024-02-02T05:07:54.539Z cypress:cli:unzip into /root/.cache/Cypress/13.6.2
2024-02-02T05:07:54.541Z cypress:cli:unzip zipFile entries count 21852
2024-02-02T05:07:54.541Z cypress:cli:unzip unzipping via `unzip`
2024-02-02T05:07:54.544Z cypress:cli:unzip unzip tool error: spawn unzip ENOENT
2024-02-02T05:07:54.544Z cypress:cli:unzip unzipping with node.js (slow)
2024-02-02T05:07:54.544Z cypress:cli:unzip calling Node extract tool /tmp/cypress-262.zip { dir: '/root/.cache/Cypress/13.6.2', onEntry: [Function: tick] }
2024-02-02T05:07:54.545Z cypress:cli:unzip unzip tool close with code -2
2024-02-02T05:07:54.545Z cypress:cli:unzip `unzip` failed { code: -2 }

In those cases, the CI stays stuck until a timeout is reached, but there shouldn't be any reason to not reject the unzip promise when no more recovery is possible.

Steps to test

n/a

How has the user experience changed?

n/a

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[CLAassistant]

All committers have signed the CLA.

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[jennifer-shehane]

@CamilleDrapier Thank you for the contribution. We'll give this a look over when we can.

[cypress-bot]

Released in 13.6.5.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.5, please open a new issue.