fix: Hanging indefinitely when unzip fails with an empty error #28850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the promise for trying to unzip with Node extract was not always either resolved or rejected. There shouldn't be a case where this shouldn't be done once the fallback has been tried.
Additional details
Sometimes on my CI, I see the following log:
In those cases, the CI stays stuck until a timeout is reached, but there shouldn't be any reason to not reject the unzip promise when no more recovery is possible.
Steps to test
n/a
How has the user experience changed?
n/a
PR Tasks
cypress-documentation
?type definitions
?