chore: additional context on protocol upload network errors #28986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in protocol uploads
1 flaky test on run #54401 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #28986 ↗︎
| @@ -323,7 +323,17 @@ export class ProtocolManager implements ProtocolManagerShape { | |||
| } | |||
| } | |||
|
|
|||
| const errorMessage = await res.json().catch(() => res.statusText) | |||
| const errorMessage = await res.json().catch(() => { | |||
| const url = new URL(uploadUrl) | |||
There was a problem hiding this comment.
Can't imagine why this wouldn't be a valid url, but should we gaurd against if this ends up raising an error as invalid?
There was a problem hiding this comment.
While investigating this, I don't think we need to guard at this point, because this code is unreachable if uploadUrl is not a valid URL: fetch on L#305 will throw in this case, which gets caught on L#345.
jennifer-shehane
approved these changes
Mar 1, 2024
cacieprins
requested review from
mschile and
ryanthemanuel
and removed request for
mschile
ryanthemanuel
approved these changes
Mar 5, 2024
cacieprins
added a commit
that referenced
this pull request
Mar 12, 2024
cacieprins
added a commit
that referenced
this pull request
Mar 12, 2024
* chore: release 13.7.0 * fix incorrect regression note in changelog * Update cli/CHANGELOG.md Co-authored-by: Matt Schile <mschile@cypress.io> * changelog entries for #28986 --------- Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Matt Schile <mschile@cypress.io>
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
HTTP status codes and URLs that fail are useful data when investigating network errors. Previously, we were only reporting the status text.
In order to reduce time spent on uploading capture databases in a failure state, retry count has been reduced from 7 to 2, for 3 total attempts.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?