Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: capture the beforeTest timestamp in the app before sending it to protocol for a more accurate timestamp #29061

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Mar 5, 2024

  • Closes N/A

Additional details

Captures the timestamp of beforeTest inside the browser to get a more accurate time for when the test actually starts. This gets sent to protocol for ingestion.

Steps to test

How has the user experience changed?

PR Tasks

@AtofStryker AtofStryker changed the title capture the beforeTest timestamp in the app before sending it to prot… chore: capture the beforeTest timestamp in the app before sending it to prot… Mar 5, 2024
Copy link

cypress bot commented Mar 5, 2024

1 flaky test on run #54441 ↗︎

0 551 8 0 Flakiness 1

Details:

Merge branch 'develop' into feat/capture_timestamp_before_test_app
Project: cypress Commit: a9def00fda
Status: Passed Duration: 13:44 💡
Started: Mar 8, 2024 11:45 PM Ended: Mar 8, 2024 11:59 PM
Flakiness  cypress/e2e/specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Screenshots

Review all test suite changes for PR #29061 ↗︎

…to protocol for a more accurate timestamp [run ci]
@AtofStryker AtofStryker force-pushed the feat/capture_timestamp_before_test_app branch from 677fdc1 to d592ce9 Compare March 5, 2024 17:03
@AtofStryker AtofStryker requested review from ryanthemanuel and mschile and removed request for ryanthemanuel March 5, 2024 21:09
@ryanthemanuel ryanthemanuel changed the title chore: capture the beforeTest timestamp in the app before sending it to prot… chore: capture the beforeTest timestamp in the app before sending it to protocol for a more accurate timestamp Mar 6, 2024
Copy link
Contributor

@mschile mschile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I think this should be a fix/misc instead of a chore.

@AtofStryker AtofStryker changed the title chore: capture the beforeTest timestamp in the app before sending it to protocol for a more accurate timestamp misc: capture the beforeTest timestamp in the app before sending it to protocol for a more accurate timestamp Mar 8, 2024
@AtofStryker AtofStryker merged commit 3383043 into develop Mar 11, 2024
79 of 82 checks passed
@AtofStryker AtofStryker deleted the feat/capture_timestamp_before_test_app branch March 11, 2024 12:54
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 13, 2024

Released in 13.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants