perf: improve replay upload resiliency #29174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacieprins
force-pushed
the
cacie/perf/improve-replay-upload-resiliency
branch
4 times, most recently
from
a03d09b
to
766051c
Compare
cacieprins
force-pushed
the
cacie/perf/improve-replay-upload-resiliency
branch
from
766051c
to
967e876
Compare
1 flaky test on run #54695 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
Review all test suite changes for PR #29174 ↗︎
AtofStryker
reviewed
Mar 26, 2024
packages/server/test/unit/cloud/upload/StreamActivityMonitor_spec.ts
Outdated
Show resolved
Hide resolved
packages/server/test/unit/cloud/api/putProtocolArtifact_spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bill Glesias <bglesias@gmail.com>
Co-authored-by: Bill Glesias <bglesias@gmail.com>
AtofStryker
approved these changes
Mar 27, 2024
packages/server/test/unit/cloud/api/put_protocol_artifact_spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bill Glesias <bglesias@gmail.com>
Co-authored-by: Bill Glesias <bglesias@gmail.com>
| @@ -3,6 +3,10 @@ | |||
|
|
|||
| _Released 4/2/2024 (PENDING)_ | |||
|
|
|||
| **Performance:** | |||
There was a problem hiding this comment.
Is this really performance? Or more stability?
There was a problem hiding this comment.
A little of A, a little of B - but the source issue is labeled performance
packages/server/lib/cloud/api/api.ts
Outdated
| @@ -9,19 +9,19 @@ const RequestErrors = require('@cypress/request-promise/errors') | |||
| const { agent } = require('@packages/network') | |||
There was a problem hiding this comment.
Not a big deal, but maybe rename this to index.ts so that we don't have to do api/api?
There was a problem hiding this comment.
Updated in 58c8daa
packages/server/test/unit/cloud/upload/stream_activity_monitor_spec.ts
Outdated
Show resolved
Hide resolved
…_spec.ts Co-authored-by: Ryan Manuel <ryanm@cypress.io>
ryanthemanuel
approved these changes
Mar 28, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Major behavioral changes:
To accomplish this:
protocol.tswas removed in favor of usingfetch-retry-ts, which adds retry logic on top of any provided fetch implementation. This is important, ascross-fetchprovides custom network agent support.HttpErrorclass, to better handle HTTP errors going forward.ProtocolManagertocloud/api/putProtocolArtifact.tsandcloud/upload/uploadStreamStreamActivityMonitorthat produces aTransformstream that monitors a givenReadable, and anAbortControllerthat will be signalled if the stream is inactive for too long. This is used inuploadStream.tsto detect stalled uploads, by piping the Test Replay archive'sfs.ReadStreamthrough the StreamActivityMonitor'sTransform.api.tstocloud/api/api.tsto keep it colocated withputProtocolArtifact.ts, which is too specific of an implementation for the parentcloud/directory.There are some slight messaging changes:
Spec recording too large: db is $SIZE bytes, limit is $LIMIT byteshas changed toSpec recording too large: artifact is $SIZE bytes, limit is $LIMIT bytes.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?