Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix driver reruns spec while recording due to weird reloading cycle #29183

Merged
merged 7 commits into from
Mar 26, 2024

Conversation

ryanthemanuel
Copy link
Collaborator

@ryanthemanuel ryanthemanuel commented Mar 21, 2024

Close #29181

Additional details

The reruns spec in the driver, has some weird reloading that occurs. It triggers a simulation of essentially reloading the page in run mode and then effectively wipes away some state that we need for protocol. Rather than trying to handle this edge case in a complicated one-off fashion, I am instead just ensuring that the protocol events fire for this one spec.

Steps to test

n/a

How has the user experience changed?

PR Tasks

@mschile mschile changed the title chore: fix driver reruns spec while recording due to weird reloading cycle test: fix driver reruns spec while recording due to weird reloading cycle Mar 21, 2024
Copy link

cypress bot commented Mar 22, 2024

3 flaky tests on run #54653 ↗︎

0 6082 86 0 Flakiness 3

Details:

Merge branch 'develop' into ryanm/chore/fix-reruns-test-due-to-protocol
Project: cypress Commit: d452e61050
Status: Passed Duration: 19:29 💡
Started: Mar 26, 2024 6:35 PM Ended: Mar 26, 2024 6:55 PM
Flakiness  commands/net_stubbing.cy.ts • 2 flaky tests • 5x-driver-chrome:beta

View Output

Test Artifacts
network stubbing > intercepting request > can delay with deprecated delayMs param Test Replay
network stubbing > waiting and aliasing > yields the expected interception when two requests are raced Test Replay
Flakiness  e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
... > throws when foo cannot resolve Test Replay

Review all test suite changes for PR #29183 ↗︎

@ryanthemanuel ryanthemanuel merged commit 11c6dd8 into develop Mar 26, 2024
80 of 82 checks passed
@ryanthemanuel ryanthemanuel deleted the ryanm/chore/fix-reruns-test-due-to-protocol branch March 26, 2024 19:03
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 2, 2024

Released in 13.7.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.7.2, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: unskip rerun.cy.js for chromium browsrs
3 participants