Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update app to cypress-example-kitchensink v2.0.5 #29235

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

MikeMcC399
Copy link
Contributor

Additional details

Updates https://example.cypress.io/ through branch gh-pages to deploy app from cypress-example-kitchensink@2.0.5.

Steps to test

Smoke test

Scaffolded test execution

Execute:

mkdir cy-test-app
cd cy-test-app
git init
npm init -y
npm install cypress
npx cypress open --e2e --browser electron

Select Continue
Select "Scaffold example specs"
Select "Okay, I got it!"
Exit Cypress Runner and Launchpad

npx cypress run

confirm all tests run successfully.

How has the user experience changed?

PR Tasks

@jennifer-shehane jennifer-shehane merged commit 8ff7dc2 into cypress-io:gh-pages Apr 1, 2024
3 checks passed
@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Unfortunately that makes it incompatible with tests which have been scaffolded using current versions including Cypress 13.7.1.

npx cypress run --spec cypress/e2e/2-advanced-examples/misc.cy.js fails

  1) Misc
       .end() - end the command chain:
     AssertionError: Timed out retrying after 4000ms: Expected to find element: `.misc-table`, but never found it.
      at Context.eval (webpack://cy-examples-test/./cypress/e2e/2-advanced-examples/misc.cy.js:13:7)

If the app example web https://example.cypress.io is supposed to be backwards compatible to scaffolding done with existing Cypress versions, then this PR would need to be reverted.

If backward compatibility is not important then the issue would sort itself out for the upcoming version 13.7.2 which has the .end() test removed from scaffolding.

@MikeMcC399 MikeMcC399 deleted the update/gh-pages branch April 2, 2024 14:50
@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Apr 2, 2024

Another finer-grained possibility would be to revert only changes to

affecting cy.end() from

then release this for cypress-example-kitchensink, merge it into cypress and publish to gh-pages.

This would give backwards compatibility to scaffolded example specs which have been set up using Cypress 13.7.1 and earlier.

Related issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants