chore: move to macstadium intel runner for circle darwinx64 [run ci] #29300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #54961 ↗︎
Details:
Review all test suite changes for PR #29300 ↗︎ |
|||||||||||||||
|
working on migrating the launch agent from 1.1 to 3.0. moving to draft until this is done |
AtofStryker
force-pushed
the
chore/move_off_circle_to_macstadium_amd64
branch
from
470454d
to
ad020c0
Compare
AtofStryker
force-pushed
the
chore/move_off_circle_to_macstadium_amd64
branch
from
091b514
to
ef1ea02
Compare
AtofStryker
force-pushed
the
chore/move_off_circle_to_macstadium_amd64
branch
from
ea43abf
to
f8da59c
Compare
AtofStryker
commented
Apr 15, 2024
| @@ -83,7 +83,7 @@ describe('http/request-middleware', () => { | |||
|
|
|||
| expect(ctx.req.headers!['x-cypress-is-from-extra-target']).not.to.exist | |||
| expect(ctx.req.isFromExtraTarget).to.be.true | |||
| expect(ctx.onlyRunMiddleware).to.be.calledWith(['MaybeSetBasicAuthHeaders', 'SendRequestOutgoing']) | |||
| expect(ctx['onlyRunMiddleware']).to.be.calledWith(['MaybeSetBasicAuthHeaders', 'SendRequestOutgoing']) | |||
There was a problem hiding this comment.
I originally fixed this due to cache issues on the mac machines, but then also realized that the stop-only script fails in local development in spots where it shouldn't. So I think these changes are warranted as the stop-only shouldn't be throwing for these as they are .only mocha tests.
cacieprins
approved these changes
Apr 16, 2024
ryanthemanuel
approved these changes
Apr 16, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Circle CI is removing intel based resource classes on mac os, so we have migrated to macstadium to build the intel binary. More can be seen in their blog post.
This means we cannot build the MacOS Intel binary on CircleCI after June 28th, 2024. We could build a composite binary for M1 and Intel, but this doubles the size of the binary and is not an option for us. To work around this, we are opting for a MacStadium Intel machine in addition to our M1 MacStadium Machine. This allows us to continue to build the intel based Mac binary at a fixed cost.
For the meantime, our M1 jobs will also run on MacStadium .
We can no longer run the kitchen sink jobs on mac intel due to the working directory being in the tmp directory, which now has persisted state. The self hosted runner configuration is not sophisticated enough to clear multiple directories. It might be possible to accomplish this with a command_prefix, but this doesn't seem worth the headache.
This also means similar to our M1 runner, our jobs will complete serially. This means if there is heavy demand to build the Mac Intel binary, the jobs will not execute and parallel and time to complete will likely be slow.
NOTE: this runner is also on CircleCI Machine runner 3.0
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?