Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: Upgrade @vue/test-utils to 2.4.5 #29441

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mbp
Copy link

@mbp mbp commented Apr 30, 2024

Additional details

Update types for mount and update peer dependency on @vue/test-utils to 2.4.5.

Steps to test

See #26628 (comment)

How has the user experience changed?

No error when running vue-tsc.

PR Tasks

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@mbp mbp changed the title Upgrade @vue/test-utils to 2.4.5 dependency: Upgrade @vue/test-utils to 2.4.5 Apr 30, 2024
@mbp
Copy link
Author

mbp commented Apr 30, 2024

@lmiller1990 could you help me to update types in npm/vue/src/index.ts like you did in #25538? I find it extremely hard to follow the instructions and copy => modify such complicated TypeScript.

@lmiller1990
Copy link
Contributor

I haven't done this in a while (not working on Cypress right now). It should be basically:

  • copy paste straight from Test Utils
  • compare to what is there already
  • I think the main change is the component property in Cypress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to use Component Testing with Vite/Vue after upgrade to TypeScript 5
4 participants