fix: pass all chromium flags through to Electron #29443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 flaky tests on run #55292 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for response to route |
Test Replay
|
|
files.cy.js • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > passes through assertion error when not about existence |
Test Replay
|
|
Review all test suite changes for PR #29443 ↗︎
mschile
reviewed
May 1, 2024
mschile
reviewed
May 1, 2024
mschile
requested changes
May 1, 2024
Co-authored-by: Matt Schile <mschile@cypress.io>
Yes 😝 Probably why a better test would be good around this. Co-authored-by: Matt Schile <mschile@cypress.io>
mschile
approved these changes
May 1, 2024
AtofStryker
approved these changes
May 1, 2024
Co-authored-by: Bill Glesias <bglesias@gmail.com>
jj497
pushed a commit
to jj497/cypress
that referenced
this pull request
May 5, 2024
* fix: pass all chromium flags through to Electron * Add changelog entry * exclude webkit from test for navigator.webdriver being true * add debug log for switches in electron * Fix the unit test so it passes now * Update packages/server/lib/environment.js Co-authored-by: Matt Schile <mschile@cypress.io> * Update packages/server/lib/environment.js Yes 😝 Probably why a better test would be good around this. Co-authored-by: Matt Schile <mschile@cypress.io> * Update packages/server/test/unit/util/chromium_flags_spec.js Co-authored-by: Bill Glesias <bglesias@gmail.com> * lint fix --------- Co-authored-by: Matt Schile <mschile@cypress.io> Co-authored-by: Bill Glesias <bglesias@gmail.com>
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This issue highlighted that there are some differences in how Electron's Chromium browser runs vs Chrome's browser due to the same Chrome flags/switches not all being passed to Electron.
You can see in many cases where we fixed a bug by passing a new Chrome flag, then later had to followup to fix another bug in Electron with the same flag.
We should send the same flags to Electron as we do Chrome.
Steps to test
navigator.webdriveristrue(there is a bug with Webkit honoring this logged here) This test indirectly tests that there is an--enable-automationflag being passed to Electron, Chrome, and Firefox. So it's not a pure test to ensure our flags are being passed correctly.How has the user experience changed?
This should resolve some situations where there's a difference in behavior between the 2 browsers. This may fix some bugs for people in Electron, but it might also introduce 'unwanted' changes in behavior (such as the original
navigator.webdriverbehavior changing which could cause user's applications to no longer load in Electron - although this is the correct behavior)PR Tasks
cypress-documentation?type definitions?