Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use 18.20.2 docker image for test-kitchensink-against-staging … #29490

Merged
merged 1 commit into from
May 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 13 additions & 1 deletion .circleci/workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ mainBuildFilters: &mainBuildFilters
- /^release\/\d+\.\d+\.\d+$/
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- 'update-v8-snapshot-cache-on-develop'
- chore/fix_kitchen_sink

# usually we don't build Mac app - it takes a long time
# but sometimes we want to really confirm we are doing the right thing
Expand Down Expand Up @@ -89,7 +90,16 @@ executors:
environment:
PLATFORM: linux
CI_DOCKER: "true"


kitchensink-executor:
docker:
- image: cypress/browsers-internal:node18.20.2-chrome124-ff125
# by default, we use "medium" to balance performance + CI costs. bump or reduce on a per-job basis if needed.
resource_class: medium
environment:
PLATFORM: linux
CI_DOCKER: "true"

# Docker image with non-root "node" user
non-root-docker-user:
docker:
Expand Down Expand Up @@ -2876,6 +2886,7 @@ linux-x64-workflow: &linux-x64-workflow
requires:
- build
- test-kitchensink-against-staging:
executor: kitchensink-executor
context: test-runner:record-tests
<<: *mainBuildFilters
requires:
Expand Down Expand Up @@ -3211,6 +3222,7 @@ linux-x64-contributor-workflow: &linux-x64-contributor-workflow
requires:
- build
- test-kitchensink-against-staging:
executor: kitchensink-executor
context: test-runner:record-tests
<<: *mainBuildFilters
requires:
Expand Down