-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove opn dep #29504
Merged
Merged
chore: remove opn dep #29504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -338,13 +337,6 @@ export class SocketBase { | |||
return options.onMocha.apply(options, args) | |||
}) | |||
|
|||
socket.on('open:finder', (p, cb = function () {}) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find this actually emitted anywhere. Maybe I'm wrong in my understanding of this though.
2 flaky tests on run #55380 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
network stubbing > intercepting request > can delay and throttle a StaticResponse |
Review all test suite changes for PR #29504 ↗︎ |
ryanthemanuel
approved these changes
May 10, 2024
mschile
approved these changes
May 10, 2024
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Originally, I was looking to replace our forked
opn
repo withpatch-package
. In looking at theopn
repo (renamed toopen
), sindresorhus had a note on the repo:That is indeed what we need this for and was not available when this was first coded.
This PR removes the
opn
dep entirely and replaces its use with Electron'sshell.openPath
.Steps to test
Unit test was updated.
I manually tested that the 'View App Data' and the 'Open in Finder' links work still on Mac.
How has the user experience changed?
The user experience should not change.
PR Tasks
cypress-documentation
?type definitions
?