fix: chrome missing CRI client after browser relaunch

[AtofStryker]

• Closes Missing browserCriClient in connectToNewSpec #27657

Additional details

This PR addresses the missing CRI client issue when chrome unexpectedly closes. When this would happen, we wait for the browser to reconnect up to 3 attempts. In this case though, since the browser closed, we closed the CRI client as well and we are able to successfully relaunch the browser, expecting the CRI client to be there, but its not so we get this error.

To fix this, we need to make sure we detect when the browser unexpectedly closes and let the launcher know that the instance is no longer active. This way, we can set shouldLaunchNewTab to false which will prompt the recreation of the CRI client as the browser instance is new.

That being said, I am unable to create a system test where the browser closes in the manner I need it to. I was only able to recreate the issue on this branch against this test suite. In the actual repo, I have added a brief assertion to the launcher unit test and added a new integration test for the run mode in the server, which integrates most the aspects of the server while stubbing out the config loader child process and a few other directory specific things since we are mocking the file system.

Steps to test

run the integration tests in the server for the monorepo, or try the specified branch (which is the reprod branch but with the fix) against the test repo to see the crash in action. You should see the log which indicates we recovered and rehydrate the CRI client correctly.

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[cypress]

5 flaky tests on run #55855 ↗︎

0

29292

1328

0

5

Details:

Merge branch 'develop' of github.com:cypress-io/cypress into fix/browser_missing...
Project: cypress	Commit: 5d46189119
Status: Passed	Duration: 21:43 💡
Started: Jun 20, 2024 3:00 PM	Ended: Jun 20, 2024 3:22 PM

  commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta

View Output

Test		Artifacts
... > errors > throws when waiting for 2nd response to route		Test Replay

  e2e/origin/navigation.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test		Artifacts
... > times out in cy.origin with foobar spec bridge defined		Test Replay

  commands/net_stubbing.cy.ts • 2 flaky tests • 5x-driver-webkit

View Output

Test		Artifacts
... > with `resourceType` > can match a proxied image request by resourceType		</td> </tr> <tr> <td colspan="2"> <a href="https://cloud.cypress.io/projects/ypt4pf/runs/55855/overview/4f8fb43b-1589-4b63-86c5-9dd18de8bc8f?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test"> ... > stops waiting when an xhr request is canceled </a> </td> <td> </td> </tr></table>   commands/waiting.cy.js • 1 flaky test • 5x-driver-webkit View Output Test Artifacts ... > errors > throws waiting for the 3rd response </td> </tr></table> Review all test suite changes for PR #29663 ↗︎

[cypress-bot]

Released in 13.13.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.13.0, please open a new issue.