dependency: Replace jsonlint with json-parse-even-better-errors

[jennifer-shehane]

• Closes CVE-2021-23358 found on trivy scan cypress version is 13.3.3 #28207

Additional details

This replaces jsonlint (which hasn't been updated in 6 years) with a more maintained package to provide json linting, json-parse-even-better-errors.

Steps to test

Existing tests have been updated, but you can run a test locally to see the error:

fixtures/bad.json

{
  "bad": "json"
  "should": "not parse"
}

test.cy.js

it('throws error on bad json', () => {
  cy.visit('index.html')
  cy.fixture('bad.json')
})

How has the user experience changed?

This does change the user experience. The json linting errors are formatted differently. It's not as good imo, but it does provide enough information to debug the issue properly. These errors only display when someone calls cy.fixture() on a JSON file that is not proper JSON, so the instances of people seeing these errors seems pretty low.

Before

After

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[cypress]

7 flaky tests on run #56128 ↗︎

0

29292

1328

0

7

Details:

Merge branch 'develop' into remove-json-lint
Project: cypress	Commit: 99b18a2c74
Status: Passed	Duration: 22:36 💡
Started: Jul 12, 2024 9:13 PM	Ended: Jul 12, 2024 9:35 PM

  e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test		Artifacts
... > past Max-Age, before Expires -> not logged in		</td> </tr></table>   commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox View Output Test Artifacts network stubbing > waiting and aliasing > can spy on a 304 not modified image response </td> </tr></table>   commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome View Output Test Artifacts ... > errors > throws when waiting for 2nd response to route Test Replay   commands/files.cy.js • 1 flaky test • 5x-driver-electron View Output Test Artifacts ... > passes through assertion error when not about existence Test Replay   commands/files.cy.js • 1 flaky test • 5x-driver-chrome:beta View Output Test Artifacts ... > passes through assertion error when not about existence Test Replay The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud. Review all test suite changes for PR #29673 ↗︎

[cypress-bot]

Released in 13.13.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.13.1, please open a new issue.