feat: Implement correct behavior for all input types supporting arrow up (stepUp) and arrow down (stepDown)

[thevladisss]

• Closes Implement correct behavior for all input types supporting arrow up (stepUp) and arrow down (stepDown) #29665

Additional details

This feature implements natural behavior of inputs that support key down and key up and also support stepper functionality (stepUp and stepDown) according to MDN Docs., affecting

cy.type action and enforcing that it mathces expected user experience

Steps to test

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[jennifer-shehane]

I manually verified this behavior works. It also works correctly when a step attribute is defined. Thanks for adding this and adding thorough tests around this!

[thevladisss]

@thevladisss There's actually some failures in CI if you have time to take a look.

https://app.circleci.com/pipelines/github/cypress-io/cypress/62518/workflows/2ad52bdb-432c-45f0-8e2e-e94bd4c1a4e2/jobs/2588309

That must be fixed by last commit now

[jennifer-shehane]

@thevladisss There’s still a failure in the type test file.

[thevladisss]

@thevladisss There’s still a failure in the type test file.

Whoops, I can see, just did not have enough time to check. I will fix in the evening

[jennifer-shehane]

@thevladisss These tests are still failing. You can run them locally and verify the type file is passing.

[thevladisss]

@thevladisss These tests are still failing. You can run them locally and verify the type file is passing.

Actually I did, I wonder why they are failing on CI. Let me troubleshoot it

[thevladisss]

@thevladisss These tests are still failing. You can run them locally and verify the type file is passing.

Actually I did, I wonder why they are failing on CI. Let me troubleshoot it

I see what the issue is. I actually only tested Chromium browsers. Appears like there is certain specific behavior with Webkit and Firefox for "stepUp" and "stepDown" functions that I would have to account for. I'll do my best to fix it during this week.

[thevladisss]

@thevladisss These tests are still failing. You can run them locally and verify the type file is passing.

Actually I did, I wonder why they are failing on CI. Let me troubleshoot it

I see what the issue is. I actually only tested Chromium browsers. Appears like there is certain specific behavior with Webkit and Firefox for "stepUp" and "stepDown" functions that I would have to account for. I'll do my best to fix it during this week.

This has been addressed. Now I am facing issue with "sessions.ui.cy.js" and hopefully because my branch is not up-to-date with development.

[jennifer-shehane]

@thevladisss It seems the webkit type tests are still failing around the stepUp/stepDown implementation: https://app.circleci.com/pipelines/github/cypress-io/cypress/62710/workflows/7da0f09a-5165-4c47-a7a4-d4e7789f58fa/jobs/2595993

[thevladisss]

@thevladisss It seems the webkit type tests are still failing around the stepUp/stepDown implementation: https://app.circleci.com/pipelines/github/cypress-io/cypress/62710/workflows/7da0f09a-5165-4c47-a7a4-d4e7789f58fa/jobs/2595993

I figured that could happen, I just cannot run tests on Webkit locally for some reason...

[thevladisss]

I do not want to delay release of this feature, therefore I added check for webkit browser, that for some reason I cannot locally debug. I am acutally struggling to run tests for some reason. I also talked to the teamember in Discord, but that unfortunately did not help me to able to run tests

[thevladisss]

@jennifer-shehane I am having issues locally debuggin implementation for Webkit. What would be your best suggestion ?

[MikeMcC399]

@thevladisss

For consistency, you could use the existing isWebKit for exceptions:

cypress/packages/driver/cypress/e2e/commands/actions/type.cy.js

Line 25 in 5c20476

const isWebKit = Cypress.isBrowser('webkit')