chore: upgrades default ts lib from es2018 + extras to full es2021 #29832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
approved these changes
Jul 10, 2024
mschile
approved these changes
Jul 11, 2024
12 flaky tests on run #56075 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > throws when alias property isnt just a digit |
Test Replay
|
|
cypress/e2e/e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ... > past Max-Age, before Expires -> not logged in |
| |||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| SidebarNavigation > expands the bar when clicking the expand button |
Test Replay
Screenshots
|
|
cypress/e2e/commands/querying/querying.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > throws when alias property isnt just a digit |
Test Replay
|
|
cypress/e2e/commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
The first 5 flaky specs are shown, see all 9 specs in Cypress Cloud.
Review all test suite changes for PR #29832 ↗︎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
@packages/serveris compiled withesnextlibs, while other packages (even ones that depend on@packages/server) are compiled withes2018(+ a fewes2021feature specific libs). This can cause ats-checkmismatch, as e.g.,@packages/net-stubbingdepends on@packages/server. If the portions of@packages/serverthat@packages/net-stubbingimports includees2021features, likeAggregateError, ts-check will fail without this.This is a fairly safe change, as it does not change the target ES version - just which polyfills Typescript will include behind the scenes.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?