-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adds tests for visibilty when clipped by ancestor overflow:hidden #29844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 flaky tests on run #56126 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
cy.origin - cookie login > Max-Age > past max-age -> not logged in |
Test Replay
|
e2e/origin/navigation.cy.ts • 1 flaky test • 5x-driver-chrome:beta
Test | Artifacts | |
---|---|---|
... > times out in cy.origin with foobar spec bridge defined |
Test Replay
|
commands/files.cy.js • 1 flaky test • 5x-driver-chrome:beta
Test | Artifacts | |
---|---|---|
... > throws a specific error when file exists when it shouldn't |
Test Replay
|
commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit
Test | Artifacts | |
---|---|---|
network stubbing > intercepting request > can delay and throttle a StaticResponse |
Review all test suite changes for PR #29844 ↗︎ |
AtofStryker
approved these changes
Jul 12, 2024
jennifer-shehane
requested changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for this slight text change
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
jennifer-shehane
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Clipping visibility logic differs based on parent or ancestor, so these tests were added.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?