Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adds tests for visibilty when clipped by ancestor overflow:hidden #29844

Merged
merged 5 commits into from
Jul 12, 2024

Conversation

cacieprins
Copy link
Contributor

Additional details

Clipping visibility logic differs based on parent or ancestor, so these tests were added.

Steps to test

How has the user experience changed?

PR Tasks

@cacieprins cacieprins marked this pull request as ready for review July 12, 2024 14:57
Copy link

cypress bot commented Jul 12, 2024

6 flaky tests on run #56126 ↗︎

0 29307 1328 0 Flakiness 6

Details:

Merge branch 'develop' into cacie/test/grandparent-visiblity
Project: cypress Commit: deba79c0d6
Status: Passed Duration: 22:33 💡
Started: Jul 12, 2024 8:41 PM Ended: Jul 12, 2024 9:03 PM
Flakiness  e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
cy.origin - cookie login > Max-Age > past max-age -> not logged in Test Replay
Flakiness  e2e/origin/navigation.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
... > times out in cy.origin with foobar spec bridge defined Test Replay
Flakiness  commands/files.cy.js • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
... > throws a specific error when file exists when it shouldn't Test Replay
Flakiness  commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/56126/overview/f388e6f2-cb6b-42e1-bcf6-5bcd8cc24879?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > with `resourceType` > can match a proxied image request by resourceType
      </a>
    </td>
    <td>
      
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/56126/overview/07090890-3dd9-4e94-81a4-69178664e9b0?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > stops waiting when an xhr request is canceled
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>

Review all test suite changes for PR #29844 ↗︎

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for this slight text change

packages/driver/cypress/e2e/dom/visibility.cy.ts Outdated Show resolved Hide resolved
@jennifer-shehane jennifer-shehane removed the request for review from mschile July 12, 2024 20:14
@jennifer-shehane jennifer-shehane self-requested a review July 12, 2024 22:59
@jennifer-shehane jennifer-shehane merged commit 48c81e3 into develop Jul 12, 2024
78 of 82 checks passed
@jennifer-shehane jennifer-shehane deleted the cacie/test/grandparent-visiblity branch July 12, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: add element grandparent visibility tests
3 participants