Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing light (300) font weight from spec links in desktop GUI #3065

Merged
merged 4 commits into from Feb 28, 2019

Conversation

5 participants
@ianwalter
Copy link
Contributor

ianwalter commented Jan 5, 2019

The list of spec names in the desktop GUI is very difficult to read because of the light font weight combined with the light blue link color on a white background. This change simply removes the font-weight: 300 CSS rule so that the links will be rendered in the default 400 weight instead.

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Jan 5, 2019

CLA assistant check
All committers have signed the CLA.

@ianwalter ianwalter changed the title Removing light (300) font weight from spec link Removing light (300) font weight from spec links in desktop GUI Jan 5, 2019

@jennifer-shehane jennifer-shehane self-assigned this Jan 7, 2019

@jennifer-shehane jennifer-shehane self-requested a review Jan 7, 2019

@jennifer-shehane jennifer-shehane removed their assignment Jan 7, 2019

@jennifer-shehane
Copy link
Member

jennifer-shehane left a comment

Removing the font-weight entirely sets the calculated font-weight to 500 or bold. I would prefer a specific font-weight: 400 over removing it entirely. See examples of how font-weight's appear on specs below:

Font-weight 300
screen shot 2019-01-07 at 3 32 36 pm

Font-weight 400
screen shot 2019-01-07 at 3 32 42 pm

Font-weight 500
screen shot 2019-01-07 at 3 32 49 pm

@lilaconlee lilaconlee merged commit e4cb364 into cypress-io:develop Feb 28, 2019

21 checks passed

ci/circleci: Linux lint Your tests passed on CircleCI!
Details
ci/circleci: Mac build Your tests passed on CircleCI!
Details
ci/circleci: Mac lint Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: desktop-gui-integration-tests-2x Your tests passed on CircleCI!
Details
ci/circleci: driver-integration-tests-3x Your tests passed on CircleCI!
Details
ci/circleci: lint-typescript Your tests passed on CircleCI!
Details
ci/circleci: run-launcher Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-8 Your tests passed on CircleCI!
Details
ci/circleci: server-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: server-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: unit-tests Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

tgriesser added a commit that referenced this pull request Mar 4, 2019

Merge branch 'develop' into typescript-server
* develop:
  Update error message when record key not found for project (#3628)
  Removing light (300) font weight from spec links in desktop GUI (#3065)
  chore(deps): update dtslint to 0.5.1 🌟 (#3611)
  separate dtslint into its own CircleCI job (#3528)
  chore(deps): update dependency enzyme-adapter-react-16 to version 1.10.0 🌟 (#3601)
  Visit with a POST and/or custom headers (#3489)
  try v8 for reporter and runner caches (#3600)
  match the reporter cache key (#3598)
  increment reporter cache key (#3596)
  Pass all extra parameters to setInterval/setTimeout callback functions (#3593)
@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Mar 15, 2019

Released in 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.