Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed outline on 'Configuration' panel heading in desktop-gui #3402

Merged
merged 4 commits into from Jul 3, 2019

Conversation

King-Kyle
Copy link
Contributor

@King-Kyle King-Kyle commented Feb 8, 2019

Removed default outline from the dropdowns under settings in issue #3357.
WIP. was unable to replicate collapsed configuration.

close #3357

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lilaconlee lilaconlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The situation described in the issue is that the only panel shown was "Configuration" and it was collapsed. When there is only one panel, it probably makes sense to show it open by default. From looking at settings.jsx, it looks like there are other panels shown if a project has a Project ID or a Record Key. The fix here would be to have the Configuration panel open by default if there are no Project ID or Record Key panels, but have it collapsed by default if those panels exist.

Feel free to give that fix a go, otherwise we can pull it into a separate issue!

packages/desktop-gui/src/settings/settings.scss Outdated Show resolved Hide resolved
@King-Kyle
Copy link
Contributor Author

Thanks for the response :). I'd like to give that other issue a try as well...Although using the command 'npm run cypress:open' from the contributing docs doesn't really help with testing in this instance as the Project ID and Record Key panels show up.
My changes don't seem to show when running 'npx cypress open' as well. Do you have any suggestions on how I could test this with the Config panel alone?
Otherwise, I think it could be moved to a separate issue if it's not a problem.

@lilaconlee
Copy link
Contributor

To work on the config panel alone, I'd recommend writing some tests in settings_spec.coffee that check whether the configuration panel is open or closed by default depending on the presence of project ID/record keys. Looks like this test has a set up where you can replicate only the configuration being shown.

You can find this in the readme, but you'll want to watch the desktop-gui files to make sure your changes show up and run the cypress tests from the desktop-gui directory.

@jennifer-shehane jennifer-shehane self-requested a review July 3, 2019 06:12
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed - the outline no longer overlaps with 'learn more'.

Screen Shot 2019-07-03 at 12 50 16 PM

Also, the 'Configuration' is no longer able to be shown by itself as every project also now has 'Proxy' panel, so the second part of auto-expanding 'Configuration' no longer needs to be addressed.

@jennifer-shehane jennifer-shehane changed the title fixed outline but not quite clear on collapse issue fixed outline on 'Configuration' panel heading in desktop-gui Jul 3, 2019
@jennifer-shehane jennifer-shehane merged commit f9750b0 into cypress-io:develop Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings / Configuration has weird outline
4 participants