New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed outline on 'Configuration' panel heading in desktop-gui #3402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The situation described in the issue is that the only panel shown was "Configuration" and it was collapsed. When there is only one panel, it probably makes sense to show it open by default. From looking at settings.jsx
, it looks like there are other panels shown if a project has a Project ID or a Record Key. The fix here would be to have the Configuration panel open by default if there are no Project ID or Record Key panels, but have it collapsed by default if those panels exist.
Feel free to give that fix a go, otherwise we can pull it into a separate issue!
Thanks for the response :). I'd like to give that other issue a try as well...Although using the command 'npm run cypress:open' from the contributing docs doesn't really help with testing in this instance as the Project ID and Record Key panels show up. |
To work on the config panel alone, I'd recommend writing some tests in You can find this in the readme, but you'll want to watch the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed default outline from the dropdowns under settings in issue #3357.
WIP. was unable to replicate collapsed configuration.
close #3357