Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] use webpack for builds #4103

Merged
merged 174 commits into from
Jul 18, 2019
Merged

[internal] use webpack for builds #4103

merged 174 commits into from
Jul 18, 2019

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented May 2, 2019 •
edited
Loading

This PR is to improve the development experience for contributors to Cypress, and should only have minor changes for Cypress users

fix #4758

features:

  • handles js, ts, coffeescript, jsx/tsx, and scss
  • runner with < 1s watch time, ~10 sec build time
  • easy to enable sourcemaps
  • chrome devtool sources are mapped to relative files via sourceURL, even without sourcemaps
  • auto-refresh browser on changes to reporter/runner/driver (optional)

changes:

build script:

  • fix issue with dangling promise during copyPackages step
  • remove use of symlinks / proxy package.jsons in final build, instead statically grep and transform require statements for symlinked packages, e.g.: require("@packages/socket/lib/server") -> require("../../socket/lib/server")
  • remove unused packages/reporter/dist(unused, 4Mb)

tasks:

  • set up build/watch tasks for runner/reporter
  • use webpack-dev-server for virtual fs (faster watch) and auto-refresh
  • split reporter into separate bundle (for testing)
  • get reporter tests passing
  • random failing tests
  • remove use of browser field (use symlinks in project root)
  • change source to not assume browser field
  • random failing server/e2e tests
  • unit snapshot test for scripts/binary/util/packages
  • make build deps DRY, only one copy of babel deps, webpack, etc.
  • removed old build scripts / zunder
  • refactored webpack / babel configs to new package packages/web-config
  • use webpack to build packages/desktop-gui
  • add e2e smoke tests to ensure final prod build is what we expect
  • only run cross-origin script error-prone e2e tests in chrome (for now)

post-tasks

  • re-add circleci cache
  • remove logic building binary on this branch in win-binary-build

@kuceb kuceb changed the title WIP add webpack WIP build runner w/ webpack May 2, 2019
kuceb added 28 commits May 2, 2019 16:54
@kuceb
fix build proccess
cf2a231
@kuceb
fix reporter build and test
76cd436
@kuceb
fix reporter test .css
cd55666
@kuceb
use apply(window, ...) since strict mode in webpack
7fe5fbe
@kuceb
temp 05/13/19 [skip ci] resolver
7244966
@kuceb
temp 05/14/19 [skip ci] webpack w/ root level symlinks
b77ac36
@kuceb
run ci
cad7fe4
@kuceb
minor fixes
09cea7b
@kuceb
fix link-packages script
aad6ead
@kuceb
hopefully fix mac build
1576309
@kuceb
re-add build-prod script in reporter
8e5de4a
@kuceb
fix typo in link-packages script
2838223
@kuceb
Merge branch 'develop' into webpack-runner
32f9c30
@kuceb
fix lint errors
ae68f6b
@kuceb
fix node-version
25cbb3e
@kuceb
namespace files in webpack
8a11acf
@kuceb
bust circle ci cache
f48a04f
@kuceb
bust circle ci cache 2
03c173c
@kuceb
remove deps
1e84ca4
@kuceb
bust circle ci cache 3
8049ea4
@kuceb
bust circle ci cache (launcher)
71827f9
@kuceb
ok circleci, you win. I will change all the cache keys
8b328cd
@kuceb
update snapshot: not sure why added stack lines
030f407
@kuceb
add mocha to reporter devDeps
0621c9c
@kuceb
separate build file for reporter
556676a
@kuceb
remove unneeded code
a2e5680
@kuceb
node-sass-globbing use relative imports for appveyor
52b3f49
@kuceb
add debugging for appveyor failure
42fb24d
bahmutov and others added 25 commits July 17, 2019 13:20
@bahmutov
print name when storing cache
8d8dd32
@bahmutov
print .bin when saving cache
28e5a74
@bahmutov
fix path to .bin
fb35f7a
@bahmutov
print launcher .bin
1df5219
@bahmutov
show .bin for desktop-gui
41b7574
@bahmutov
print bins
d258f58
@kuceb
update npm version
204e1e5
@kuceb
update npm version - try 2
727ddb0
@kuceb
update npm version - try 3
530705d
@kuceb
remove circleci debugging print commands
248966e
@kuceb
Revert "remove circleci debugging print commands"
cf77273 
This reverts commit 248966e.
@bahmutov
add TERM=xterm to Circle
dc77c94
@bahmutov
Revert "Revert "remove circleci debugging print commands""
12550e8 
This reverts commit cf77273.
@kuceb
Revert "add TERM=xterm to Circle"
c078e62 
This reverts commit dc77c94.
@kuceb
remove --serial arg from run all scripts
e672db4
@kuceb
add web-config package to cache
01dc67b
@kuceb
simplify circleci build job
7dc1e82
@kuceb
circleci: try rmrf node_modules/@packages before install
90eba4a
@kuceb
appveyor: try removing --serial from install script
7ef619f
@kuceb
Merge remote-tracking branch 'origin/develop' into webpack-runner
7281a6d
@kuceb
Revert "appveyor: try removing --serial from install script"
dd193f2 
This reverts commit 7ef619f.
@kuceb
use appveyor from develop
1986a84
@kuceb
use preinstall removing subpackage symlinks
513835c 
fix webpack config typescript errors
fix path to rebuild-node-sass in packages/web-config
assert replace minimum number of symlink requires
@kuceb
test binary build [build binary]
d702a52
@kuceb
fix transformRequires code [build binary]
0944a34
@kuceb
Copy link
Contributor Author

kuceb commented Jul 18, 2019

e2e test failing unrelated

@brian-mann brian-mann merged commit 7857dac into develop Jul 18, 2019
@cypress-bot cypress-bot bot mentioned this pull request Jul 18, 2019
Closed
@jennifer-shehane jennifer-shehane mentioned this pull request Nov 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mann brian-mann brian-mann approved these changes

@bahmutov bahmutov Awaiting requested review from bahmutov

@chrisbreiding chrisbreiding Awaiting requested review from chrisbreiding

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[internal] use webpack for building desktop-gui, reporter, runner
5 participants
@kuceb @chrisbreiding @bahmutov @FrozenPandaz @brian-mann