move close too quickly check into CLI (DISPLAY re-try) #4186

bahmutov · 2019-05-13T20:53:48Z

revert the changes to cypress.coffee from https://github.com/cypress-io/cypress/pull/4165/files#diff-fbc9f64a5652c9142e1ab0a9d54272a0
instead measure how long it takes to spawn the process in the CLI

bahmutov · 2019-05-13T20:55:14Z

cli/lib/exec/spawn.js


-        if (shouldRetryOnDisplayProblem && code === POTENTIAL_DISPLAY_PROBLEM_EXIT_CODE) {
+        if (shouldRetryOnDisplayProblem &&
+          isPotentialDisplayProblem(os.platform(), process.env.DISPLAY, code, elapsed)) {


now this should work with both debug version of Electron in the monorepo and with compiled Cypress binary app

brian-mann · 2019-05-17T06:41:03Z

CONTRIBUTING.md

@@ -317,6 +317,24 @@ cd packages/desktop-gui
 npm rebuild node-sass
 ```

+#### Docker for built binary


@bahmutov Don't we already have a docker script that does this?

It's just npm run docker. Am I misunderstanding?

move close too quick check into CLI

490251c

bahmutov commented May 13, 2019

View reviewed changes

bahmutov requested a review from kuceb May 13, 2019 20:55

kuceb approved these changes May 13, 2019

View reviewed changes

bahmutov merged commit b219189 into develop May 13, 2019

brian-mann reviewed May 17, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move close too quickly check into CLI (DISPLAY re-try) #4186

move close too quickly check into CLI (DISPLAY re-try) #4186

bahmutov commented May 13, 2019

bahmutov May 13, 2019

brian-mann May 17, 2019

move close too quickly check into CLI (DISPLAY re-try) #4186

move close too quickly check into CLI (DISPLAY re-try) #4186

Conversation

bahmutov commented May 13, 2019

bahmutov May 13, 2019

Choose a reason for hiding this comment

brian-mann May 17, 2019

Choose a reason for hiding this comment