Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency fs-extra to version .x 🌟 #4555

Merged
merged 1 commit into from Jun 25, 2019

Conversation

2 participants
@renovate
Copy link
Contributor

commented Jun 25, 2019

This PR contains the following updates:

Package Type Update Change
fs-extra dependencies major 4.0.3 -> 5.0.0
fs-extra devDependencies major 4.0.3 -> 5.0.0

Release Notes

jprichardson/node-fs-extra

v5.0.0

Compare Source

Significant refactor of copy() & copySync(), including breaking changes. No changes to other functions in this release.

Huge thanks to @​manidlou for doing most of the work on this release.

  • The filter option can no longer be a RegExp (must be a function). This was deprecated since fs-extra v1.0.0. #​512
  • copy()'s filter option can now be a function that returns a Promise. #​518
  • copy() & copySync() now use fs.copyFile()/fs.copyFileSync() in environments that support it (currently Node 8.5.0+). Older Node versions still get the old implementation. #​505
  • Don't allow copying a directory into itself. #​83
  • Handle copying between identical files. #​198
  • Error out when copying an empty folder to a path that already exists. #​464
  • Don't create dest's parent if the filter function aborts the copy() operation. #​517
  • Fix writeStream not being closed if there was an error in copy(). #​516

Renovate configuration

πŸ“… Schedule: "before 3am on the first day of the month" in timezone America/New_York.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

πŸ”• Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@jennifer-shehane
Copy link
Member

left a comment

It seems they mostly changed fs.copy and fs.copySync so that

  • you cannot copy the same file into itself - maybe it's symlinked or whatever - it will error now.
  • They also removed the ability to filter by RegExp with the filter opt in copy / copySync - I don't see us using this option anywhere in our code.

LGTM

@jennifer-shehane jennifer-shehane merged commit c2d9ae4 into develop Jun 25, 2019

23 checks passed

ci/circleci: Linux lint Your tests passed on CircleCI!
Details
ci/circleci: Mac build Your tests passed on CircleCI!
Details
ci/circleci: Mac lint Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: desktop-gui-integration-tests-2x Your tests passed on CircleCI!
Details
ci/circleci: driver-integration-tests-3x Your tests passed on CircleCI!
Details
ci/circleci: lint-typescript Your tests passed on CircleCI!
Details
ci/circleci: reporter-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: run-launcher Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-8 Your tests passed on CircleCI!
Details
ci/circleci: server-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: server-performance-tests Your tests passed on CircleCI!
Details
ci/circleci: server-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: unit-tests Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@renovate renovate bot deleted the renovate/fs-extra-5.x branch Jun 25, 2019

@cypress-bot

This comment has been minimized.

Copy link

commented Jun 27, 2019

Released in 3.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.