Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NO_PROXY=<-loopback>, always have NO_PROXY=localhost otherwise #4800

Merged
merged 4 commits into from
Aug 2, 2019

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jul 24, 2019

Pre-merge Tasks

@flotwig flotwig changed the title Support NO_PROXY=<-loopback>, always have NO_PROXY=localhost otherwise [WIP] Support NO_PROXY=<-loopback>, always have NO_PROXY=localhost otherwise Jul 24, 2019
@cypress
Copy link

cypress bot commented Aug 2, 2019



Test summary

2882 0 37 1


Run details

Project cypress
Status Timedout
Commit 390ae4b
Started Aug 2, 2019 6:37 PM
Ended Aug 2, 2019 8:44 PM
Duration 07:37 💡
OS Linux Debian - 8.10
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig changed the title [WIP] Support NO_PROXY=<-loopback>, always have NO_PROXY=localhost otherwise Support NO_PROXY=<-loopback>, always have NO_PROXY=localhost otherwise Aug 2, 2019
@flotwig flotwig requested a review from a team August 2, 2019 19:09
@brian-mann brian-mann merged commit 92b91fe into develop Aug 2, 2019
grabartley pushed a commit to grabartley/cypress that referenced this pull request Oct 6, 2019
…ress-io#4800)

* localhost is always in NO_PROXY unless <-loopback> specified

* tests

* fix failing specs

* update test to use <-loopback>
@flotwig flotwig deleted the issue-4780 branch January 24, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support NO_PROXY=<-loopback>, always have NO_PROXY=localhost otherwise
2 participants