Informative error when invalid CYPRESS_INSTALL_BINARY #5060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasbjerre
changed the title
This was referenced Aug 29, 2019
I had CYPRESS_INSTALL_BINARY set to "'http://serrver.com/'" (including single quotes). And I did not get an informative error stating that this was the case. Closes #5059 Closes #5062
bahmutov
reviewed
Sep 10, 2019
| @@ -128,6 +128,31 @@ const downloadAndUnzip = ({ version, installDir, downloadDir }) => { | |||
| return Promise.resolve(tasks.run()) | |||
| } | |||
|
|
|||
| const INSTALL_BINARY_TYPES = { | |||
| URL: (c) => /^https?:\/\/.*/.test(c), | |||
| FS: (c) => fs.pathExistsSync(c), | |||
There was a problem hiding this comment.
due to file system on Mac locking up with too many M files, we use gracefulfs to retry file access. Which means that ALL file operations have to be async, and we should never use ...Sync versions. Could you change this code to check for file existence to be async, please?
bahmutov
reviewed
Sep 10, 2019
| return throwFormErrorText(errors.cypressInstallBinaryInvalid)(needVersion) | ||
| } | ||
|
|
||
| debug(`Identified CYPRESS_INSTALL_BINARY as type: ${needVersionType}`) |
There was a problem hiding this comment.
does this work? What does it print - the function name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had
CYPRESS_INSTALL_BINARYset to'http://serrver.com/'(including single quotes). And I did not get an informative error stating that this was the case.Pre-merge Tasks