Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not keeping track of correct URL when setting cookies durin… #5455

Merged
merged 5 commits into from
Oct 25, 2019

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Oct 24, 2019

User facing changelog

Fixed a regression in 3.5.0 where cookies may not be set on the correct URL during a redirect inside of a cy.visit() or cy.request().

Additional details

  • The code in request.coffee never actually kept track of the correct URL
  • This was fine before, because the cookies were just stored in a JAR which had other ways of tracking the URL
  • After Electron upgrade PR Electron v5.0.10 #4720, newUrl started to be used to set the cookies via CDP, which was a problem since newUrl would always be equal to the original options.url
  • This fixes the failing SSO test in cypress-example-recipes

PR Tasks

  • Have tests been added/updated?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 24, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@flotwig flotwig changed the title [WIP] Fix not keeping track of correct URL when setting cookies during a redirect Fix not keeping track of correct URL when setting cookies during a redirect Oct 24, 2019
@flotwig flotwig requested review from brian-mann, bahmutov and a team October 24, 2019 19:23
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, passes the failing example recipe now

@flotwig flotwig changed the title Fix not keeping track of correct URL when setting cookies during a redirect Fix not keeping track of correct URL when setting cookies durin… Oct 25, 2019
@flotwig flotwig merged commit 4b278f8 into develop Oct 25, 2019
@flotwig flotwig deleted the issue-5432-sso-failure branch January 24, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookies not being sent in redirect in 3.5.0
2 participants