Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make background.js writable before overwriting it #5579

Closed
wants to merge 2 commits into from
Closed

Make background.js writable before overwriting it #5579

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a8fea9
Make background.js writable before overwriting it
rasendubi Nov 1, 2019
9f5789a
Merge branch 'develop' into background-js-eaccess
rasendubi Nov 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/server/lib/browsers/chrome.coffee
View file
Open in desktop
Expand Up @@ -224,6 +224,10 @@ module.exports = {

## copy the extension src to the extension dist
utils.copyExtension(pathToExtension, extensionDest)
.then ->
## make background.js writable (in case it was copied from a
## read-only partition)
fs.chmodAsync(extensionBg, 0o0644)
.then ->
## and overwrite background.js with the final string bytes
fs.writeFileAsync(extensionBg, str)
Expand Down