-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cli dependencies #5684
Upgrade cli dependencies #5684
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
"url": "0.11.0", | ||
"yauzl": "2.10.0" | ||
}, | ||
"devDependencies": { | ||
"@cypress/sinon-chai": "1.1.0", | ||
"@types/blob-util": "1.3.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@types/blob-util
is deprecated, since blob-util
now bundles its own type definitions.
@singingwolfboy Closing in favor of #4226 which does exactly this. A large amount of the upgrades are breaking changes - dropping Node 4 and 6, which is why we have it slated for the breaking change release of Cypress. We use renovatebot to update dependencies one by one for better tracking generally, so do not generally consider PRs for dep updates outside of the flow. See our Contributing guide for more detail. I will open a new issue concerning @types/blob-util dep. Thanks! |
The
cli/package.json
file declares a lot of dependencies, and they are all pinned to exact versions. This means they fall out of date quickly, and any other project that depends oncypress
must pull in these old versions of these dependencies forcypress
.This pull request updates all dependencies in
cli/package.json
. This is probably more extreme than what we want, but it's a good first pass to see how much we need to change the code to accommodate these dependency updates. I'm happy to break this up into smaller pull requests, if asked.