Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cli dependencies #5684

Closed

Conversation

singingwolfboy
Copy link

The cli/package.json file declares a lot of dependencies, and they are all pinned to exact versions. This means they fall out of date quickly, and any other project that depends on cypress must pull in these old versions of these dependencies for cypress.

This pull request updates all dependencies in cli/package.json. This is probably more extreme than what we want, but it's a good first pass to see how much we need to change the code to accommodate these dependency updates. I'm happy to break this up into smaller pull requests, if asked.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 13, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2019

CLA assistant check
All committers have signed the CLA.

"url": "0.11.0",
"yauzl": "2.10.0"
},
"devDependencies": {
"@cypress/sinon-chai": "1.1.0",
"@types/blob-util": "1.3.3",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@types/blob-util is deprecated, since blob-util now bundles its own type definitions.

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Dec 19, 2019

@singingwolfboy Closing in favor of #4226 which does exactly this.

A large amount of the upgrades are breaking changes - dropping Node 4 and 6, which is why we have it slated for the breaking change release of Cypress.

We use renovatebot to update dependencies one by one for better tracking generally, so do not generally consider PRs for dep updates outside of the flow. See our Contributing guide for more detail.

I will open a new issue concerning @types/blob-util dep. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants