Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simply state that the element is not visible. #5982

Merged
merged 1 commit into from Dec 18, 2019
Merged

Simply state that the element is not visible. #5982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/driver/src/dom/visibility.js
View file
Open in desktop
Expand Up @@ -521,7 +521,7 @@ ${covered}\
}
}

return `Cypress could not determine why this element '${node}' is not visible.`
return `This element '${node}' is not visible.`
}
/* eslint-enable no-cond-assign */

Expand Down
2 changes: 1 addition & 1 deletion packages/driver/test/cypress/integration/dom/visibility_spec.js
View file
Open in desktop
Expand Up @@ -1051,7 +1051,7 @@ This element '<div#coveredUpPosFixed>' is not visible because it has CSS propert
})

it('cannot determine why element is not visible', function () {
this.reasonIs(this.$btnOpacity, 'Cypress could not determine why this element \'<button>\' is not visible.')
this.reasonIs(this.$btnOpacity, 'This element \'<button>\' is not visible.')
})
})
})
Expand Down