Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated request library dependency #6679

Closed
JustFly1984 opened this issue Mar 9, 2020 · 4 comments · Fixed by #6694
Closed

Replace deprecated request library dependency #6679

JustFly1984 opened this issue Mar 9, 2020 · 4 comments · Fixed by #6694
Labels
process: dependencies Related to internal dependencies type: chore Work is required w/ no deliverable to end user

Comments

@JustFly1984
Copy link

Current behavior:

Request library is deprecated. Getting this message on installing packages in logs.

Desired behavior:

Replace request with maintained alternative like node-fetch

Test code to reproduce

just run yarn add request
@JustFly1984
Copy link
Author

request/request#3142

@jennifer-shehane jennifer-shehane added process: dependencies Related to internal dependencies type: chore Work is required w/ no deliverable to end user labels Mar 10, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Mar 10, 2020
@jennifer-shehane jennifer-shehane changed the title request@2.88.0: request has been deprecated, see https://github.com/request/request/issues/3142 Replace deprecated request library dependency Mar 10, 2020
@jennifer-shehane
Copy link
Member

Alternatives to request: request/request#3143

Technically we have replaced our dependency of request with our own branch requiring cypress-io/request#b5af0d1fa47eec97ba980cde90a13e69a2afcd16, although it seems not all packages are using this - and some are still using 2.88.0.

https://github.com/cypress-io/request

@jennifer-shehane jennifer-shehane mentioned this issue Mar 10, 2020
Merged
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope labels Mar 11, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Mar 11, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 11, 2020

The code for this is done in cypress-io/cypress#6694, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 16, 2020

Released in 4.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
process: dependencies Related to internal dependencies type: chore Work is required w/ no deliverable to end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sync all 'request' deps to use the cypress fork cypress-io/cypress
2 participants
@jennifer-shehane @JustFly1984