Fix deprecation warnings from Electron 8 upgrade

[flotwig]

• Closes Deprecation warnings from electron / node during cypress open #6750

User facing changelog

• Fixed a regression in 4.2.0 where Electron deprecation warnings were printed to stderr in open mode.

Additional details

• now, objects sent via IPC in open mode are cloned to exclude functions and elements, to make the Structured Clone Algorithm usable: https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm
• previously, allowRendererProcessReuse was only set in run mode, now it's set in open mode too to get rid of the warning
• now we set noDeprecation when the env is production, so no deprecation warnings will be printed in built binaries

PR Tasks

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?
• [na] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[cypress]

---

Test summary

6989 • 0 • 97 • 0

---

Run details

Project	cypress
Status	Passed
Commit	af408c7
Started	Mar 17, 2020 5:30 PM
Ended	Mar 17, 2020 5:36 PM
Duration	06:10 💡
OS	Linux Debian - 10.1
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[bahmutov]

is there a test for this?

[flotwig]

no, i can add tests, just wasn't sure where to add them... probably just need to add tests for the ipc-bus file

[bahmutov]

it would be nice to send an object from the browser with functions and elements and ping it back from the server - and the receiver would check if the returned object has invalid fields stripped

[flotwig]

added ipc_bus specs: https://github.com/cypress-io/cypress/pull/6753/files#diff-0bf397162937f0ddea8c95e4dd3e3033

[bahmutov]

so beautiful