isolated runner changes #6799
isolated runner changes #6799
Conversation
|
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
ugh, this edit: needed to clear |
kuceb
force-pushed
the
isolated-runner-fixes
branch
from
d1bc9ea
to
8031a43
Compare
There was a problem hiding this comment.
Is there a reason not to merge this into develop branch?
TODO: Running tests in runner needs instructions in the README.md, right now it only describes how to run unit tests - does not describe how to start server and run cypress tests.
I'm a little unclear about the overlap of these tests versus the reporter/cypress/integration tests. Are these meant to replace those entirely? Cause some of the things they're tested seem duplicated. Maybe I'm wrong here though.
…erna' into chore-move-driver-tests-into-parent
…tests-into-parent
…tests-into-parent
kuceb
force-pushed
the
isolated-runner-fixes
branch
from
774249e
to
3f4d7df
Compare
| // disable DOM snapshots during log for this agent | ||
| agent.snapshot = (bool = true) => { | ||
| agent._noSnapshot = !bool | ||
|
|
||
| return agent | ||
| } | ||
|
|
There was a problem hiding this comment.
might be a better / more readable API to do...
agent.log = (options) => {
if (options && options.snapshot === false) {
// do the thing
}
})There was a problem hiding this comment.
Or more like agent.options or agent.logOptions
packages/runner/cypress.json
Outdated
| "hosts": { | ||
| "*.foobar.com": "127.0.0.1" | ||
| } |
| @@ -32,6 +32,12 @@ const socketRerunEvents = 'runner:restart watched:file:changed'.split(' ') | |||
| const localBus = new EventEmitter() | |||
| const reporterBus = new EventEmitter() | |||
|
|
|||
| if (window.Cypress) { | |||
| window.channel = ws | |||
There was a problem hiding this comment.
This is already exposed via line 19
Also we may just want to nest these underneath window.runnerWs (and rename that)
window.eventManager = { backendBus, reporterBus, localBus }
There was a problem hiding this comment.
let's add a note reflecting on why this is a weird shape - that we only want to expose this within the test environment, but because we use an e2e test that uses it, we either need to move that test to isolated-runner or find a 2nd way to expand the conditional.
| } | ||
|
|
||
| describe('src/cypress/runner', () => { | ||
| describe('tests finish with correct state', () => { |
There was a problem hiding this comment.
runner.mochaEvents.spec move all the tests that snapshot mocha event structures to their own file
| @@ -0,0 +1,54 @@ | |||
| /** | |||
There was a problem hiding this comment.
move this to a separate draft PR
| .html(btnIcon.html().replace(/\n/g, '<br/>')) | ||
| }, | ||
| click () { | ||
| const prev = Cypress.env('SNAPSHOT_UPDATE') |
There was a problem hiding this comment.
don't use Cypress.env, just put this on a global since we intend to move away from the current Cypress.env implementation
| }, function () { | ||
| }) |
| @@ -1,60 +1,369 @@ | |||
| exports['lib/reporter #stats has reporterName stats, reporterStats, etc 1'] = { | |||
| exports['simple_single_test runner emit'] = [ | |||
packages/server/test/matchDeep.js
Outdated
| @@ -0,0 +1,124 @@ | |||
| const _ = require('lodash') | |||
| @@ -0,0 +1,92 @@ | |||
| /* eslint-disable prefer-rest-params */ | |||
| @@ -1,162 +1,248 @@ | |||
| require('../spec_helper') | |||
| * @param {()=>void | {[key:string]: any}} mochaTests | ||
| * @param {{state?: any, config?: any}} opts | ||
| */ | ||
| const runCypress = (mochaTests, opts = {}) => { |
Closes N/A (internal only)
chunk of feat: support test retries #3968
cleanup cy/Cypress globals to allow testing cypress-in-cypress
add
runner/integration - runner.spec.jsthat tests cypress runner as the AUTadd
server/unit - reporter.spec.jsthat tests reporter from event snapshot data generated inrunner/integration - runner.spec.jsPotential Tests to move into runner/integration
User facing changelog
N/A
Additional details
isolated runner:
yes:
no:
misc:
implementation:
packages/runner/cypress/integrationHow has the user experience changed?
Internal Only
added snapshot/diff utility with helpful diff error message
which is the result of this diff
update snapshots by toggling this ui button
PR Tasks