Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaffeinate #7097

merged 4 commits into from Apr 23, 2020

Decaffeinate #7097

merged 4 commits into from Apr 23, 2020


Copy link

@flotwig flotwig commented Apr 21, 2020

No description provided.

Copy link

cypress-bot bot commented Apr 21, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).


  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.


  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).


  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.


  • The original issue has been tagged with a release in ZenHub.

Copy link

cypress bot commented Apr 21, 2020

Test summary

7182 0 98 0

Run details

Project cypress
Status Passed
Commit 69cfbad
Started Apr 21, 2020 7:18 PM
Ended Apr 21, 2020 7:25 PM
Duration 06:20 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig marked this pull request as ready for review April 22, 2020 14:34
@flotwig flotwig requested review from a team, kuceb and CypressJoseph and removed request for a team April 22, 2020 14:34
@jennifer-shehane jennifer-shehane requested review from jennifer-shehane and removed request for kuceb and CypressJoseph April 23, 2020 07:43
Copy link

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feel free to request my review for decaff PRs. I welcome the monotony.

This file is SUPER long though. I'd suggest splitting it into more manageable files if possible.

@jennifer-shehane jennifer-shehane merged commit cda67b1 into develop Apr 23, 2020
Copy link
Contributor Author

flotwig commented Apr 23, 2020

Looks good. Feel free to request my review for decaff PRs. I welcome the monotony.


This file is SUPER long though. I'd suggest splitting it into more manageable files if possible.

Agreed, I've actually been wanting to split the request functionality off into its own package for a while, but have not had a good reason. It's gnarly and dense with logic.

Copy link

cypress-bot bot commented Apr 28, 2020

Released in 4.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 28, 2020
@flotwig flotwig deleted the decaf-request branch January 24, 2022 18:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants