-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(server): increase timeout when making Marionette connection #7372
Conversation
Previously, retries were deferred to the Marionette library, which only retried for 2.5 seconds. Now, it will retry for up to 20 seconds, which matches what we do for Foxdriver and CDP. Also, errors from Foxdriver + Marionette connections are now wrapped.
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
d95bafa
to
8da1e79
Compare
…tte-connection-timeout
84e2b30
to
a3bed44
Compare
User facing changelog
Additional details
2050 seconds, which matches what we do for Foxdriver and CDP.How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?