Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: install specific Node version on Mac before building binary #8242

Merged
merged 28 commits into from
Aug 11, 2020
Merged

chore: install specific Node version on Mac before building binary #8242

merged 28 commits into from
Aug 11, 2020

Commits on Aug 10, 2020

  1. try installing Node on Mac before building

    @bahmutov
    bahmutov committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    14d6995 View commit details
    Browse the repository at this point in the history

  2. build mac binary in this branch

    @bahmutov
    bahmutov committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    19acb72 View commit details
    Browse the repository at this point in the history

  3. try next Mac executor version

    @bahmutov
    bahmutov committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    0b4da7f View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. move install node into command

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    7efbc78 View commit details
    Browse the repository at this point in the history

  2. read node version from .node-version file

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    634254b View commit details
    Browse the repository at this point in the history

  3. hmm

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    0497baa View commit details
    Browse the repository at this point in the history

  4. try previous mac executor

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    d785ad1 View commit details
    Browse the repository at this point in the history

  5. print folders

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    111fc53 View commit details
    Browse the repository at this point in the history

  6. install nvm using curl

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    b502f10 View commit details
    Browse the repository at this point in the history

  7. split into two commands

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    d51ff1c View commit details
    Browse the repository at this point in the history

  8. copy to .nvmrc

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    2565679 View commit details
    Browse the repository at this point in the history

  9. add alias default

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    8af3e62 View commit details
    Browse the repository at this point in the history

  10. see if nvm dir is set

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    445fc07 View commit details
    Browse the repository at this point in the history

  11. print home .nvm

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4e44c47 View commit details
    Browse the repository at this point in the history

  12. move load nvm into a script

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    78376f1 View commit details
    Browse the repository at this point in the history

  13. why is shell script not working

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    61a8365 View commit details
    Browse the repository at this point in the history

  14. try using dot

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    f86884e View commit details
    Browse the repository at this point in the history

  15. use dot in second place

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    af1af47 View commit details
    Browse the repository at this point in the history

  16. use load nvm in several places

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    60d0f0c View commit details
    Browse the repository at this point in the history

  17. set version

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    c91a360 View commit details
    Browse the repository at this point in the history

  18. do not skip Node version check on Mac Circle

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    6589128 View commit details
    Browse the repository at this point in the history

  19. more nvm

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    388139c View commit details
    Browse the repository at this point in the history

  20. install Node for jobs

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    939aa02 View commit details
    Browse the repository at this point in the history

  21. move command

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    7e694ea View commit details
    Browse the repository at this point in the history

  22. adding crash pad handler to the list of binaries

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    13be75a View commit details
    Browse the repository at this point in the history

  23. upgrade electron builder

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    eecfe39 View commit details
    Browse the repository at this point in the history

  24. nvm for binary zip

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    8123fbc View commit details
    Browse the repository at this point in the history

  25. merged v5.0-release

    @bahmutov
    bahmutov committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    ff07a32 View commit details
    Browse the repository at this point in the history