Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Style of 'Waiting for browser login' button #8269

Merged
merged 5 commits into from
Aug 13, 2020

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Aug 13, 2020

TR-238

User Changelog

N/A - fixing prereleased UI

Additional Details

  • PENDING: percy snapshots did not ask for review of new snapshots
  • I added percy snapshots throughout the login spec for uniquely styled views
  • I also changed the style of the 'Continue' button to match the new blue button styles (missed this in last UI PR)

How has the user experience changed?

Before (Waiting button)

Screen Shot 2020-08-13 at 1 26 21 PM

After (Waiting button)

Screen Shot 2020-08-13 at 1 24 15 PM

Before (Continue button)

Screen Shot 2020-08-13 at 1 25 45 PM

After (Continue button)

Screen Shot 2020-08-13 at 1 24 41 PM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 13, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Aug 13, 2020



Test summary

7940 0 130 2


Run details

Project cypress
Status Passed
Commit e463b4c
Started Aug 13, 2020 6:59 AM
Ended Aug 13, 2020 7:06 AM
Duration 06:33 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@bahmutov
Copy link
Contributor

By looking at the CircleCI desktop-gui-visual-job output I see the Percy build URL https://percy.io/cypress-io/cypress/builds/6488128 with the correct new snapshots, total of 19 snapshots.

Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, looks really nice

@bahmutov bahmutov merged commit cb19f77 into develop Aug 13, 2020
@jennifer-shehane
Copy link
Member Author

Gosh, why doesn't that show up in the status check link.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 20, 2020

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants