Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate cy.route(), remove experimentalNetworkStubbing flag #9185

Merged

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Nov 12, 2020

TR-493

User facing changelog

  • cy.route() and cy.server() have been deprecated and will be moved to a plugin in a future release. Consider using cy.http() instead.
  • The experimentalNetworkStubbing flag has been removed and cy.http() is now always available.

Additional details

How has the user experience changed?

After

During cypress open or cypress run is experimentalNetworkStubbing is present:

Screen Shot 2020-11-17 at 2 56 05 PM

In Console log during cypress open when using cy.server() or cy.route()

Screen Shot 2020-11-17 at 2 55 00 PM

PR Tasks

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 12, 2020

Thanks for taking the time to open a PR!

works around over-application of `selfProxy` opt
@cypress
Copy link

cypress bot commented Nov 13, 2020



Test summary

8713 0 118 3Flakiness 1


Run details

Project cypress
Status Passed
Commit af26ac9
Started Nov 17, 2020 3:37 PM
Ended Nov 17, 2020 3:50 PM
Duration 12:56 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig force-pushed the deprecate-cy.route-remove-experimentalNetworkStubbing branch from bca48bf to 159bfdd Compare November 16, 2020 17:02
@flotwig flotwig marked this pull request as ready for review November 16, 2020 17:43
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion. Looks good otherwise.

I wish we had the display of warnings in the Command Log to make these notices more obvious.

packages/server/lib/errors.js Outdated Show resolved Hide resolved
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
@flotwig flotwig merged commit 3fec100 into v6.0-release Nov 17, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 24, 2020

Released in 6.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 24, 2020
@flotwig flotwig deleted the deprecate-cy.route-remove-experimentalNetworkStubbing branch January 24, 2022 18:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants