Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cypress/unsafe-to-chain-command not exported from the package #125

Closed
Michsior14 opened this issue Mar 28, 2023 · 6 comments
Closed

cypress/unsafe-to-chain-command not exported from the package #125

Michsior14 opened this issue Mar 28, 2023 · 6 comments

Comments

@Michsior14
Copy link

Michsior14 commented Mar 28, 2023

The latest version (2.13.0) leads to error during eslint execution:

 error  Definition for rule 'cypress/unsafe-to-chain-command' was not found  cypress/unsafe-to-chain-command

Looks like it's not exported in index.js file: https://github.com/cypress-io/eslint-plugin-cypress/blob/master/index.js#L11

@Erik-Outreach
Copy link
Contributor

Here's a PR to solve the issue: #126

@nagash77
Copy link
Contributor

This issue should be resolved in the latest release. I am going to close this issue. If the latest release does not address your issue please throw a comment here and we can reopen and investigate further.

@nagash77 nagash77 removed their assignment Mar 29, 2023
@alistaireverett
Copy link

I think this still isn't fixed, we're getting the same error now using 2.13.3. I think L11 in unsafe-to-chain-command.js should be:

ruleTester.run('unsafe-to-chain-command', rule, {

rather than 'action-ends-chain'

ruleTester.run('action-ends-chain', rule, {

@alistaireverett
Copy link

Hmm, just noticed this is in the tests, so should really affect us. Does anyone else still have this issue? Otherwise it might be something we need to fix

@TD-DO
Copy link

TD-DO commented Jul 10, 2023

I have this issue and would like to see it resolved, please

@nagash77
Copy link
Contributor

@alistaireverett and @TD-DO , please open a new issue with a reproducible example and the Cypress team will be happy to investigate. You can reference this issue in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants