Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESLint 8.x #89

Closed
Tracked by #25
MichaelDeBoey opened this issue Oct 10, 2021 · 4 comments · Fixed by #176
Closed
Tracked by #25

Support ESLint 8.x #89

MichaelDeBoey opened this issue Oct 10, 2021 · 4 comments · Fixed by #176

Comments

@MichaelDeBoey
Copy link

ESLint v8.0.0 is released 🎉

It would be awesome to have official ESLint 8 support. 👊
I'm happy to help where I can of course 🙂

@MikeMcC399
Copy link
Collaborator

@MichaelDeBoey

It seems that in practice the plugin does already support ESLint 8.x even if there is no official statement about it.

On the Cypress repo cypress-io/cypress-example-kitchensink the current version eslint-plugin-cypress@2.15.1 is already being used successfully with the full set of Cypress scaffolded examples and the latest ESLint 8.x (eslint@8.57.0) release.

What is missing:

  1. The CircleCI tests should test the plugin using ESLint 8.x. Currently they only test ESLint 4, 5 and 6, although in fact ESLint 7 and 8 also work (issue CircleCI tests only old eslint versions v4, v5 & v6 #157).
  2. ESLint 8 shows deprecation warnings when testing the rules with Jest (Eslint 8 deprecated rules context: planned failure Eslint 9 #154). This doesn't prevent the tests from running, however this issue should be addressed. It is also a pre-requisite for ESLint 9 support (issue Eslint 9 fails with legacy config .eslintrc #156).

I hope to be able to submit a set of PRs to allow testing and support of ESLint 5 to 9 and again hopefully we will be able to close your issue once CircleCI is proving that the plugin is tested againt ESLint 8!

@MikeMcC399
Copy link
Collaborator

@MikeMcC399
Copy link
Collaborator

@cypress-app-bot
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants