Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 'unsafe-to-chain-command' added as recommended rule #119

Conversation

Erik-Outreach
Copy link
Contributor

No description provided.

@Erik-Outreach Erik-Outreach changed the title chore: 'unsafe-to-chain-command' added as recommended rule feat: 'unsafe-to-chain-command' added as recommended rule Dec 29, 2022
@Erik-Outreach
Copy link
Contributor Author

@BlueWinds did you have time to check on the deployment process and merging this extra PR? Please let me know if there's anything I can help with

@nagash77 nagash77 self-assigned this Jan 23, 2023
@BlueWinds BlueWinds merged commit 3be1490 into cypress-io:master Jan 23, 2023
@BlueWinds
Copy link
Contributor

@BlueWinds did you have time to check on the deployment process and merging this extra PR? Please let me know if there's anything I can help with

I haven't had time to look into the deployment process. Going to see if anyone else on the team has some eyes to look into it.

@nagash77 nagash77 removed their assignment Feb 15, 2023
@Erik-Outreach
Copy link
Contributor Author

@BlueWinds did you have time to check on the deployment process and merging this extra PR? Please let me know if there's anything I can help with

I haven't had time to look into the deployment process. Going to see if anyone else on the team has some eyes to look into it.

@BlueWinds Did you find someone to have some eyes on it? It seems to me it's only some permission issue where the GH_TOKEN configured in CircleCI doesn't have the access to push changes in master: https://app.circleci.com/pipelines/github/cypress-io/eslint-plugin-cypress/127/workflows/2ccaa96c-c4ac-4613-9a40-bb75dc0eb9d9/jobs/512

@nagash77
Copy link
Contributor

🎉 This PR is included in version 2.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nagash77
Copy link
Contributor

Hi @Erik-Outreach , thanks for the reminder. I took a look this morning and fixed the token issue and everything should be back on track.

@Erik-Outreach
Copy link
Contributor Author

Hi @Erik-Outreach , thanks for the reminder. I took a look this morning and fixed the token issue and everything should be back on track.

Thank you! Unfortunately I might have missed one thing in my change and the latest release doesn't work. I'll push one more change shortly

@Erik-Outreach
Copy link
Contributor Author

Hi @Erik-Outreach , thanks for the reminder. I took a look this morning and fixed the token issue and everything should be back on track.

Fix here: #126 - Apologises for the mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants