Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement no-exclusive-tests rule #148

Conversation

NoyanSeckin
Copy link

This rule prevents the usage of .skip and .only in tests.
(If approved, I can write the test cases for the rule)

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link

@jennifer-shehane jennifer-shehane changed the title Implement no-exclusive-tests rule feat: Implement no-exclusive-tests rule Jan 19, 2024
@MikeMcC399
Copy link
Collaborator

@NoyanSeckin

I'm currently proposing some updates to this repo and I noticed your PR. I suggest instead of creating a new rule for eslint-plugin-cypress, use rules from eslint-plugin-mocha.

See the existing rules from eslint-plugin-mocha:

You can see an example of how eslint-plugin-cypress and eslint-plugin-mocha are combined In the cypress-io/cypress-example-kitchensink repo.

@MikeMcC399
Copy link
Collaborator

@MikeMcC399
Copy link
Collaborator

@NoyanSeckin

Thanks for the suggestion in your PR! I'm going to close it now for several reasons:

I understand that the PR was not complete when you submitted it because you were looking for feedback. Because the PR is incomplete it also fails linting.

@MikeMcC399 MikeMcC399 closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants