chore: add .node-version & .nvmrc 16.15.0 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AtofStryker
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Thanks for doing this @MikeMcC399. This repo needs some renovations 😅
I didn't realize until I starting digging in to it, just how many different places need tweaking and they are generally all interrelated, so it's difficult to know what the best order is. Thanks for merging this PR. There will be some more! |
|
🎉 This PR is included in version 2.15.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm cion repo source #153Issue
It is not possible to install the dependencies of the source of this repo using
npm ci(without the option--legacy-peer-deps) under currently supported Node.js versions18.xand later.Node.js
v16.15.0/ npm8.5.5is the last version wherenpm cistill succeeded.With Node.js
v16.15.1/ npm8.11.0, executingnpm cifails.yarn installcompletes with warnings, however since the repo includes a package-lock.json (from npm) and circle.yml, as CI workflow, installs dependencies with npm, Yarn should not be a consideration at this point.Change
Add the files
.node-version.nvmrcwith contents
16.15.0to clarify the current Node.js compatibility. This is consistent with the usage of this two files in other Cypress repos such as cypress-io/cypress-realworld-app.You can find a list of tools on node-version-usage to switch the version of
Node.jsbased on .node-version.This should be a temporary measure until compatibility with a supported version of Node.js is achieved.
Verification
On Ubuntu 22.04.4 LTS with n installed:
Execute:
and confirm that Node.js 16.15.0 is installed.
Execute:
and confirm that the installation of dependencies is successful (with warnings).