-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add no-exclusive-tests rule #25
Conversation
I like it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RoryH Thanks this is great. I agree its definitely needed, but we should probably just use https://github.com/lo1tuma/eslint-plugin-mocha. There are other useful rules in there too like no-indentical-title
and no-nested-tests
(and we could mutate the error messages to say Cypress instead of mocha if we wanted).
We obviously wouldn't want to use it as a plugin however since users would have to install both plugins, which would be awful.
What do you think, would you find any of those other rules useful @RoryH?
@bkucera I had considered possibly re-using eslint-plugin-mocha somehow but this is my first time diving into eslint plugins 🤓 . How do you see it working without adding it as an extra dependency, would it be transitive dependency of eslint-plugin-cypress? |
@RoryH we add it as a dependency, but we require the rules directly, like they do in this file https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/index.js |
I like it... If you guys are happy I'll close this PR and open a new one pulling in the rules from |
@RoryH sounds great |
…lobals-13.17.0 chore(deps): bump globals from 13.16.0 to 13.17.0
Adds rule similar to other test frameworks to identify exclusive tests.
https://mochajs.org/#exclusive-tests