fix: Fix crashing bug in no-force rule when using spread operator

[emilgoldsmith]

This was causing my Eslint to crash, I think on the cy.document({ log: false }) nodes if someone is interested in that, so just quickly fixed it

[chrisbreiding]

Thanks! Could you add a test for it please?

[emilgoldsmith]

Hi chris. I can, but it would have to wait at least until my next free weekend which is in at least 2 weeks, you or someone else are welcome to add it and merge it before if you have the bandwidth earlier though

…

On Mon, 26 Apr 2021 at 16.30, Chris Breiding ***@***.***> wrote: Thanks! Could you add a test for it <https://github.com/cypress-io/eslint-plugin-cypress/blob/master/tests/lib/rules/no-force.js> please? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#79 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEKO66VLG5KZYJSDBMXCJ3DTKV2IVANCNFSM43OSPQFQ> .

[emilgoldsmith]

Actually I have some time now on this random Monday as I'm recovering from a full on weekend so this is actually a nice little task, so I'll do that now :)

[emilgoldsmith]

Okay added!

It looks like it was the spread operator that was causing issues, I used a trimmed down version for exactly what fails of the example that had failed in my own code as the test case.

I had to first debug that it wasn't parsing the spread operator, which was because the test ecmaVersion was too low so I upped that, and I also noticed that there were a lot of redundant error options for the valid test cases which aren't even part of the spec so I removed those, hope that's okay too

[chrisbreiding]

Awesome - thanks again!

[chrisbreiding]

🎉 This PR is included in version 2.11.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀