Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cypress Dashboard Support #36

Closed
prescottprue opened this issue Nov 21, 2019 · 4 comments
Closed

Improve Cypress Dashboard Support #36

prescottprue opened this issue Nov 21, 2019 · 4 comments

Comments

@prescottprue
Copy link
Contributor

prescottprue commented Nov 21, 2019

There are a few things happening when using with Cypress Dashboard:

  1. Commit message is not showing, instead a somewhat unclear of merge info is included even though no merge is going on (see picture below)
  2. The branch name doesn't show at all (usually above the commit message)
  3. The environment shows up as "Unknown". For Gitlab it shows "Gitlab feat: custom test command #123" the number being the build number. Maybe for this it could be a link to the action run? (see picture below)
  4. Quitting a Github Action run while it is running test leaves the run in the dashboard in the "running" state (as if the dashboard was never notified about the cancel)

image

Not sure if this is the right code base for the changes, but wanted to get it reported

@bahmutov
Copy link
Contributor

Let's wait until cypress-io/cypress#5687 is released in 3.7.0 it should fix 2 and 3. For 1 - this is pull request event right, so I am not sure what a beter name would be ;)

@prescottprue
Copy link
Contributor Author

prescottprue commented Dec 10, 2019

#4 is still an issue for us - should I open a new issue for that?

@bahmutov
Copy link
Contributor

@prescottprue not sure what you mean - #4 is MacOS caching? Maybe open a new issue with details

@prescottprue
Copy link
Contributor Author

prescottprue commented Dec 10, 2019

Item 4 in the above list is what I was referencing, but it picked up that as an issue link since I included the #

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants